Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat : memberStatus 를 추가로 반환 및 member 객체 null 에 대한 처리 #52

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Feat : memberStatus 를 추가로 반환 및 member 객체 null 에 대한 처리 #52

merged 1 commit into from
Sep 17, 2024

Conversation

jsilver01
Copy link
Member

@jsilver01 jsilver01 commented Sep 17, 2024 •
edited by Mouon
Loading

요약 (Summary)

  • memberStatus 를 다시 추가해야해서 추가했습니다! 나머지 로직은 기존과 동일합니다.

🔑 변경 사항 (Key Changes)

  • memberStatus 추가로 LoginResponse 수정이 이루어졌습니다.

📝 리뷰 요구사항 (To Reviewers)

  • 데이터베이스에 없는 유저라도 memberStatus = false 라고 반환되며, githubId 만 유효한 값으로 반환되는지
  • 데이터베이스에 있는 유저라면 memberStatus = true 에 모든 값들이 채워져서 반환되는지

@Mouon Mouon changed the title feat : memberStatus 를 추가로 반환 및 member 객체 null 에 대한 처리 Feat : memberStatus 를 추가로 반환 및 member 객체 null 에 대한 처리 Sep 17, 2024
@Mouon
Copy link
Member

Mouon commented Sep 17, 2024

변경사항 모두 확인했습니다!!!
잦은 요구사항 변경으로 힘드셨을텐데 정말 수고하셨어요!
응답 모두 정상적입니다!

Mouon
Mouon reviewed Sep 17, 2024
View reviewed changes
src/main/java/com/linkode/api_server/dto/member/LoginResponse.java
return LoginResponse.builder()
.memberId(member.getMemberId())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

복잡한 요구사항인데 정팩매를 잘 적용하신거같아 좋아보여요!

@Mouon Mouon added the Feature Make Feat label Sep 17, 2024
@Mouon Mouon merged commit cd56aad into develop Sep 17, 2024
@Mouon Mouon deleted the LINKODE-79-BE-소셜로그인응답수정 branch September 17, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mouon Mouon Mouon left review comments

Assignees
No one assigned
Labels
Feature Make Feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsilver01 @Mouon