elbepack: cdroms: use source name of pkgs with on_src_cd attribute

[martin-29]

Resolve the corresponding source name of the binary packages where the XML attribute on_src_cd="False" is set.
Until now the binary name was used, which doesn't work when the source name differs to the binary name of the package. The forbiddenPackages list, containing the binary package names will be resolved and the corresponding source package names are stored in the forbiddenSrcPackages list which is then used for the comparison inside the add_source_pkg function.

[t-8ch]

If this is a set() then the duplicate entry check is not necessary

[t-8ch]

This doesn't seem correct.

If multiple packages share the same Build-Using and only one of the binary packages is excluded from the source cdrom, then that exclusion will override all others.
This is especially problematic if some base Debian packages have been used to build some excluded package.

The correct solution seems to need to go away from "on_src_cd" to some external explicit list.
However as a good-enough solution it should be fine to add a (keyword only) parameter to get_corresponding_source_packages() to inhibit Build-Using handling.

[martin-29]

Ok I didn't had in mind, that the build dependencies are then also excluded.

And I agree a separate list would make the things more visible.

I'm not 100% sure if I understand the proposed good-enough solution correctly.

You mean something like the following approach?

forbidden_src_packages = set()
for name, _ in cache.get_corresponding_source_packages(forbidden_packages, parse_build_depends=False):
    forbidden_src_packages.add(name)

def get_corresponding_source_packages(cache, pkg_lst=None, parse_build_depends=True):

    if pkg_lst is None:
        pkg_lst = {p.name for p in cache if p.is_installed}

    src_set = set()

    for pkg in pkg_lst:
        if isinstance(pkg, str):
            version = cache[pkg].installed or cache[pkg.candidate]
        elif isinstance(pkg, PackageBase):
            version = cache[pkg.name].versions[pkg.installed_version]

        src_set.add((version.source_name, version.source_version))

        if parse_build_depends:
            for name, ver in parse_built_using(version.record.get('Built-Using')):
                src_set.add((name, ver))

    return list(src_set)

def get_corresponding_source_packages(self, pkg_lst=None, parse_build_depends=True):
    return get_corresponding_source_packages(self.cache, pkg_lst, parse_build_depends)

[t-8ch]

You mean something like the following approach?

Yes, but:

• Name the new argument include_built_using
• Make it kwargs only (self, pkg_lst=None, *, include_built_using=True)
• The new method shouldn't be necessary

[t-8ch]

While you are at it, please rename it to snake_case.

[t-8ch]

Please also add newsfragments/ entry.

[t-8ch]

Thanks!
I'll also test this a bit and include it in the next release.

[martin-29]

Great thanks!