Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 38 #99

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Issue 38 #99

wants to merge 4 commits into from

Conversation

yanniboi
Copy link
Contributor

This is a follow up pull request for: #49

@yanniboi
Copy link
Contributor Author

So it turns out that the phpunit-core runner requires a webserver.

drupal_ti_run_server uses drush runserver which requires Drupal to be installed. I tried to replace drush runserver with php -S to start a webserver, however this breaks clean urls as drush runserver does some fancy php file inclusions to populate the $_GET['q'] parameter.

All this said, we probably dont need to decouple Drupal download and installation as there are now (again) no runners that require Drupal to be downloaded but not installed.

So a simple changing of drupal_ti_ensure_module to drupal_ti_ensure_module_linked in phpunit-core/before_script.sh is probably all this really needs.

Thoughts?

@coveralls
Copy link

coveralls commented Jan 23, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 2fd9c16 on yanniboi:issue-38 into 9b963a2 on LionsAd:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2fd9c16 on yanniboi:issue-38 into 9b963a2 on LionsAd:master.

@mradcliffe
Copy link

My initial use case before drupalci supported composer was that I did not want to install Drupal at all because my phpunit tests did not depend on a Drupal installation. And then I would run phpunit directly rather than via scripts/run-tests.sh

My main use case was xero, but I can test that on drupal.org now.

@yanniboi
Copy link
Contributor Author

I guess we could provide a variable that could be set to false if no functional phpunit tests exist. Then phpunit can run without Drupal installed and without webserver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants