Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LF-3800 Fixing White screen when user tries to add custom revenue. #2964

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

kikemarquez8
Copy link
Contributor

What I think its going on is the persistedFormData is not being saved fast enough for the AddSale component to retrieve it on the first render and since it's trying to destructure an object on that render it fails. As a temporary fix, just using the object instead of destructuring works.

Also removing <= validation on finances that should be "<"

Jira link:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

 What I think its going on is the persistedFormData is not being saved fast enough for the AddSale component to retrieve it on the first render and since it's trying to destructure an object on that render it fails. As a temporary fix, just using the object instead of destructuring works.

 Also removing <= validation on finances that should be "<"
@kikemarquez8 kikemarquez8 requested review from a team as code owners November 10, 2023 04:30
@kikemarquez8 kikemarquez8 requested review from antsgar and Duncan-Brain and removed request for a team November 10, 2023 04:30
Copy link
Collaborator

@kathyavini kathyavini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Kike!!! Sorry for completely missing that it was the key and not the entity that was undefined!

Works great! 👌

@kathyavini kathyavini merged commit 0111ea5 into integration Nov 16, 2023
2 checks passed
@kathyavini kathyavini deleted the bugfix/LF-3800-3764 branch November 16, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants