Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rate limit to 100r/s #2991

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Update rate limit to 100r/s #2991

merged 1 commit into from
Nov 15, 2023

Conversation

SayakaOno
Copy link
Collaborator

Description

The current rate limit is 50r/s whereas about 70 requests are sent on the home page, which makes the finance page (and other pages) crash.
This PR raise the limit to 100r/s.

Screenshot 2023-11-15 at 2 00 39 PM

Jira link:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@SayakaOno SayakaOno requested review from a team as code owners November 15, 2023 22:54
@SayakaOno SayakaOno requested review from antsgar and kathyavini and removed request for a team November 15, 2023 22:54
@SayakaOno SayakaOno self-assigned this Nov 15, 2023
Copy link
Collaborator

@kathyavini kathyavini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, and that would make sooooo much sense if this was the root issue 😄

@kathyavini kathyavini merged commit 69e5cf6 into integration Nov 15, 2023
@kathyavini kathyavini deleted the Rate_limit_100 branch November 15, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants