Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #2993

Merged
merged 9 commits into from
Nov 16, 2023
Merged

Small fixes #2993

merged 9 commits into from
Nov 16, 2023

Conversation

antsgar
Copy link
Collaborator

@antsgar antsgar commented Nov 16, 2023

Description

  • I noticed sometimes with slow networks, the transactions started showing up before the expense/revenue types loaded and the types showed up as undefined.EXPENSE_NAME. I altered the order of the fetching so we get the types first and the expenses/sales second, but I also added a fallback just in chase so we'll show an empty string if the type is undefined and gracefully load the types.
  • Fixed buttons font which for some reason is different from the rest of the app.
  • Fixed a story that's failing because of an incorrect import.
  • Fixed French translation extra comma.

Jira link:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@antsgar antsgar requested review from a team as code owners November 16, 2023 17:52
@antsgar antsgar requested review from SayakaOno and kathyavini and removed request for a team November 16, 2023 17:52
Copy link
Collaborator

@kathyavini kathyavini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@kathyavini kathyavini merged commit 1a45e30 into integration Nov 16, 2023
@kathyavini kathyavini deleted the various-fixes branch November 16, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants