Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LF-3778d Clean up unused translations using i18n script #3000

Merged
merged 1 commit into from
Nov 17, 2023
Merged

LF-3778d Clean up unused translations using i18n script #3000

merged 1 commit into from
Nov 17, 2023

Conversation

kathyavini
Copy link
Collaborator

Description

Again 😳

Jira link: https://lite-farm.atlassian.net/browse/LF-3778

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Passes test case
  • UI components visually reviewed on desktop view
  • UI components visually reviewed on mobile view
  • Other (please explain)

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The precommit and linting ran successfully
  • I have added or updated language tags for text that's part of the UI
  • I have added "MISSING" for all new language tags to languages I don't speak
  • I have added the GNU General Public License to all new files

@kathyavini kathyavini requested review from a team as code owners November 17, 2023 22:50
@kathyavini kathyavini requested review from antsgar and SayakaOno and removed request for a team November 17, 2023 22:50
SayakaOno
SayakaOno approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@SayakaOno SayakaOno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SayakaOno SayakaOno merged commit 1c71ce6 into integration Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SayakaOno SayakaOno SayakaOno approved these changes

@antsgar antsgar Awaiting requested review from antsgar antsgar is a code owner automatically assigned from LiteFarmOrg/mandatory-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kathyavini @SayakaOno