Several improvements to logging (#407)

- Shows role instead of user id in logs, e.g. `jvyden420 (Admin)`
- Logs authentication successes, e.g. when a user logs in, logs out, or
refreshes a token
- Logs assets that were uploaded and who uploaded them

Refresh.GameServer/Endpoints/ApiV3/AuthenticationApiEndpoints.cs

@@ -88,6 +88,8 @@ public ApiResponse<IApiAuthenticationResponse> Authenticate(RequestContext conte
 
         Token token = database.GenerateTokenForUser(user, TokenType.Api, TokenGame.Website, TokenPlatform.Website);
         Token refreshToken = database.GenerateTokenForUser(user, TokenType.ApiRefresh, TokenGame.Website, TokenPlatform.Website, GameDatabaseContext.RefreshTokenExpirySeconds);
+
+        context.Logger.LogInfo(BunkumCategory.Authentication, $"{user} successfully logged in through the API");
 
         return new ApiAuthenticationResponse
         {
@@ -109,6 +111,8 @@ public ApiResponse<IApiAuthenticationResponse> RefreshToken(RequestContext conte
         GameUser user = refreshToken.User;
 
         Token token = database.GenerateTokenForUser(user, TokenType.Api, TokenGame.Website, TokenPlatform.Website);
+
+        context.Logger.LogInfo(BunkumCategory.Authentication, $"{user} successfully refreshed their token through the API");
 
         return new ApiAuthenticationResponse
         {
@@ -134,6 +138,8 @@ public ApiOkResponse ResetPassword(RequestContext context, GameDatabaseContext d
 
         database.SetUserPassword(user, passwordBcrypt);
         database.RevokeTokenByTokenData(body.ResetToken, TokenType.PasswordReset);
+
+        context.Logger.LogInfo(BunkumCategory.Authentication, $"{user} successfully reset their password");
 
         return new ApiOkResponse();
     }
@@ -159,7 +165,7 @@ public ApiOkResponse SendPasswordResetEmail(RequestContext context,
         context.Logger.LogTrace(RefreshContext.PasswordReset, "Reset token: {0}", token.TokenData);
         smtpService.SendPasswordResetRequest(user, token.TokenData);
 
-        context.Logger.LogTrace(RefreshContext.PasswordReset, "Email sent, token will expire at {0}", token.ExpiresAt);
+        context.Logger.LogInfo(RefreshContext.PasswordReset, "Email sent, token will expire at {0}", token.ExpiresAt);
         return new ApiOkResponse();
     }
 
@@ -168,6 +174,7 @@ public ApiOkResponse SendPasswordResetEmail(RequestContext context,
     public ApiOkResponse RevokeThisToken(RequestContext context, GameDatabaseContext database, Token token)
     {
         database.RevokeToken(token);
+        context.Logger.LogInfo(BunkumCategory.Authentication, $"{token.User} logged out");
         return new ApiOkResponse();
     }
 

Refresh.GameServer/Endpoints/Game/Handshake/AuthenticationEndpoints.cs

@@ -165,6 +165,8 @@ public class AuthenticationEndpoints : EndpointGroup
         //Clear the user's force match
         database.ClearForceMatch(user);
 
+        context.Logger.LogInfo(BunkumCategory.Authentication, $"{user} successfully logged in on {game} via {platform}");
+
         if (game == TokenGame.LittleBigPlanetPSP)
         {
             return new TicketLoginResponse
@@ -270,7 +272,8 @@ public Response RevokeThisToken(RequestContext context, GameDatabaseContext data
 
         if (!result)
             return Unauthorized;
-
+
+        context.Logger.LogInfo(BunkumCategory.Authentication, $"{user} logged out");
         return OK;
     }
 }

Refresh.GameServer/Endpoints/Game/ResourceEndpoints.cs

@@ -95,6 +95,7 @@ public Response UploadAsset(RequestContext context, string hash, string type, by
 
         database.IncrementUserFilesizeQuota(user, body.Length);
 
+        context.Logger.LogInfo(BunkumCategory.UserContent, $"{user} uploaded a {gameAsset.AssetType} ({body.Length / 1024f:F1} KB)");
         return OK;
     }
 

Refresh.GameServer/Types/UserData/GameUser.cs

@@ -120,7 +120,7 @@ [Ignored] public GameUserRole Role
     // ReSharper disable once InconsistentNaming
     internal byte _Role { get; set; }
 
-    public override string ToString() => $"{this.Username} ({this.UserId})";
+    public override string ToString() => $"{this.Username} ({this.Role})";
 
     #region Rate-limiting
     public bool RateLimitUserIdIsEqual(object obj)