Return 404 not found on favouriteSlots when user is not found

LittleBigRefresh · Oct 3, 2023 · 758b590 · 758b590
1 parent 9434804
commit 758b590
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/Refresh.GameServer/Endpoints/Game/Levels/LevelEndpoints.cs b/Refresh.GameServer/Endpoints/Game/Levels/LevelEndpoints.cs
@@ -116,10 +116,14 @@ public SerializedMinimalLevelList GetLevelsFromCategory(RequestContext context,
         => this.GetLevels(context, database, categories, matchService, user, token, "newest");
 
     [GameEndpoint("favouriteSlots/{username}", ContentType.Xml)]
+    [NullStatusCode(NotFound)]
     [MinimumRole(GameUserRole.Restricted)]
     public SerializedMinimalFavouriteLevelList? FavouriteLevels(RequestContext context, GameDatabaseContext database, CategoryService categories, MatchService matchService, Token token, string username)
     {
-        SerializedMinimalLevelList? levels = this.GetLevels(context, database, categories, matchService, database.GetUserByUsername(username), token, "favouriteSlots");
+        GameUser? user = database.GetUserByUsername(username);
+        if (user == null) return null;
+
+        SerializedMinimalLevelList? levels = this.GetLevels(context, database, categories, matchService, user, token, "favouriteSlots");
         if (levels == null) return null;
 
         return new SerializedMinimalFavouriteLevelList(levels);