fixup for dumb bad code not clearing score events when levels are del…

…eted (#247) :( Closes #246
LittleBigRefresh · Nov 3, 2023 · eb0651e · eb0651e
2 parents 8ed5bcf + c500292
commit eb0651e
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 4 deletions.
diff --git a/Refresh.GameServer/Database/GameDatabaseContext.Levels.cs b/Refresh.GameServer/Database/GameDatabaseContext.Levels.cs
@@ -115,10 +115,10 @@ public void DeleteLevel(GameLevel level)
     {
         this._realm.Write(() =>
         {
-            IQueryable<Event> events = this._realm.All<Event>()
+            IQueryable<Event> levelEvents = this._realm.All<Event>()
                 .Where(e => e._StoredDataType == (int)EventDataType.Level && e.StoredSequentialId == level.LevelId);
 
-            this._realm.RemoveRange(events);
+            this._realm.RemoveRange(levelEvents);
 
             #region This is so terrible it needs to be hidden away
 
@@ -138,6 +138,14 @@ public void DeleteLevel(GameLevel level)
             this._realm.RemoveRange(uniquePlayLevelRelations);
 
             IQueryable<GameSubmittedScore> scores = this._realm.All<GameSubmittedScore>().Where(r => r.Level == level);
+
+            foreach (GameSubmittedScore score in scores)
+            {
+                IQueryable<Event> scoreEvents = this._realm.All<Event>()
+                    .Where(e => e._StoredDataType == (int)EventDataType.Score && e.StoredObjectId == score.ScoreId);
+                this._realm.RemoveRange(scoreEvents);
+            }
+
             this._realm.RemoveRange(scores);
 
             #endregion

diff --git a/Refresh.GameServer/Database/GameDatabaseProvider.cs b/Refresh.GameServer/Database/GameDatabaseProvider.cs
@@ -32,7 +32,7 @@ protected GameDatabaseProvider(IDateTimeProvider time)
         this._time = time;
     }
 
-    protected override ulong SchemaVersion => 95;
+    protected override ulong SchemaVersion => 96;
 
     protected override string Filename => "refreshGameServer.realm";
 
@@ -233,6 +233,7 @@ protected override void Migrate(Migration migration, ulong oldVersion)
         // IQueryable<dynamic>? oldEvents = migration.OldRealm.DynamicApi.All("Event");
         IQueryable<Event>? newEvents = migration.NewRealm.All<Event>();
 
+        List<Event> eventsToNuke = new();
         for (int i = 0; i < newEvents.Count(); i++)
         {
             // dynamic oldEvent = oldEvents.ElementAt(i);
@@ -246,6 +247,19 @@ protected override void Migrate(Migration migration, ulong oldVersion)
 
             // Converts events to use millisecond timestamps
             if (oldVersion < 33 && newEvent.Timestamp < 1000000000000) newEvent.Timestamp *= 1000;
+
+            // fixup for dumb bad code not clearing score events when levels are deleted
+            if (oldVersion < 96 && newEvent.StoredDataType == EventDataType.Score)
+            {
+                GameSubmittedScore? score = migration.NewRealm.All<GameSubmittedScore>().FirstOrDefault(s => s.ScoreId == newEvent.StoredObjectId);
+                if(score == null) eventsToNuke.Add(newEvent);
+            }
+        }
+
+        // realm won't let you use an IEnumerable in RemoveRange. too bad!
+        foreach (Event eventToNuke in eventsToNuke)
+        {
+            migration.NewRealm.Remove(eventToNuke);
         }
 
         // IQueryable<dynamic>? oldTokens = migration.OldRealm.DynamicApi.All("Token");
@@ -306,7 +320,7 @@ protected override void Migrate(Migration migration, ulong oldVersion)
             }
         }
 
-        //Remove all scores with a null level, as in version 92 we started tracking story leaderboards differently
+        // Remove all scores with a null level, as in version 92 we started tracking story leaderboards differently
         if (oldVersion < 92) migration.NewRealm.RemoveRange(migration.NewRealm.All<GameSubmittedScore>().Where(s => s.Level == null));
 
         IQueryable<dynamic>? oldScores = migration.OldRealm.DynamicApi.All("GameSubmittedScore");