Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement count query parameter for play/user/{id} #197

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Implement count query parameter for play/user/{id} #197

merged 2 commits into from
Oct 16, 2023

Conversation

Beyley
Copy link
Member

@Beyley Beyley commented Oct 14, 2023

This is only used on PSP, so the logic is only enabled on PSP callers

Closes #178

@Beyley Beyley requested a review from jvyden October 16, 2023 02:49
jvyden
jvyden approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@jvyden jvyden left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, missed this one. I think there should be a limit but it's not too big of a deal since we primarily use unique plays rather than total plays.

@jvyden jvyden added this pull request to the merge queue Oct 16, 2023
Merged via the queue into LittleBigRefresh:main with commit 60722bb Oct 16, 2023
@Beyley Beyley deleted the user-play-count branch October 16, 2023 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvyden jvyden jvyden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Batched level plays (ex: /lbp/play/user/1?count=3).
2 participants
@Beyley @jvyden