Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track more asset metadata #261

Merged
merged 7 commits into from
Nov 9, 2023
Merged

Conversation

jvyden
Copy link
Member

@jvyden jvyden commented Nov 9, 2023

Closes #24 and closes #66

This PR implements support for parsing the dependency tree in binary game assets, and records the size of all assets.

@jvyden jvyden requested a review from Beyley November 9, 2023 01:13
Copy link
Member

@Beyley Beyley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a small perf note, other than that it looks good

Refresh.GameServer/Importing/AssetImporter.cs Outdated Show resolved Hide resolved
@Beyley
Copy link
Member

Beyley commented Nov 9, 2023

side note: i wonder if this could be used to "garbage collect" some types of unreferenced assets

@jvyden
Copy link
Member Author

jvyden commented Nov 9, 2023

Probably not worth chasing. Assets are small, best not to accidentally remove something that's in use when we're not expecting it.

@jvyden jvyden requested a review from Beyley November 9, 2023 22:04
@jvyden jvyden merged commit 376b8fd into LittleBigRefresh:main Nov 9, 2023
1 check passed
@jvyden jvyden deleted the more-asset-metadata branch September 12, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement sizeOfResources on Levels User content metadata tracking
2 participants