Make RandomLevelsCategory use seed from game #323
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #122
Why
Previously, we were using a globally shared instance of
Random
when calculating the random order of levels. This caused levels to appear multiple times in the list and caused others to get potentially missed entirely.By using a consistent seed we can negate both of those problems and ensure the full list gets hit consistently.
How
To fix, introduce the client's
seed
parameter as an available parameter to use in the filter settings. We can then use this to create a newRandom
object on each call ofGetRandomLevel()
with the new seed.Remarks
This will require a change in
refresh-web
to make the website generate a random seed, since if we do not find a seed value server-side we simply use0
.