Track the platform scores were achieved on #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #241
Why
The main reason we'd want to do this is not only is it a cool metric to track, but also the fact that we support both PS3 and RPCS3, and naturally RPCS3 can be more susceptible to gameplay glitches depending on your settings. I just think it's better to distinguish the two in some way.
Eventually down the line, we'll also be able to track PPSSPP or Vita3K when those two games achieve networking support in LBP for the same reasons.
How
We simply add a new property onto
GameSubmittedScorethat contains the platform. Then, we use a best-effort migration that tries to match each game to the most relevant platform. For the mainline games, this will be PS3, LBP Vita is Vita, and LBP PSP is PSP.We obviously can't go back in time and tell if a particular score was done on RPCS3 so we just assume PS3 for now since that seems to be the more popular choice anyways.
We also expose the game version and platform the score was performed on to the API.