Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split GameComment into GameProfileComment and GameLevelComment #561

Merged
merged 8 commits into from
Jul 18, 2024

Conversation

jvyden
Copy link
Member

@jvyden jvyden commented Jul 15, 2024

Another change for Postgres. Closes #503

This PR splits the GameComment type into dedicated tables/types for each place a comment can be posted. This has the downside of having lots of duplicated code but I've tried to minimize that as much as I can

This is a draft because I have not implemented migration steps to carry old comments over to the new format as I await code review.

@jvyden jvyden requested a review from Beyley July 15, 2024 23:12
@jvyden jvyden requested a review from Beyley July 18, 2024 01:14
@jvyden jvyden marked this pull request as ready for review July 18, 2024 01:14
@jvyden jvyden merged commit ea79b12 into LittleBigRefresh:main Jul 18, 2024
2 checks passed
@jvyden jvyden deleted the comments-refactor branch July 18, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments refactor
2 participants