DigestMiddleware: Move code to use IncrementalHash #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces allocations, and increases performance
… multi-digest works
LBP3 gets mad with `/eula` if the server digest is incorrect, and since it doesn't send a client digest for that endpoint, we are unable to guess the correct digest for LBP3 clients. Also fixes the server locking in the wrong digest on endpoints which expect a server digest, but dont send a client digest. Now it will only lock in the digest for requests which contain a client digest.
jvyden
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces allocations, and increases performance.
This PR also adds more tests to our digest code.