Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag modded levels + per-user mod filtering #638

Merged
merged 15 commits into from
Aug 26, 2024

Conversation

Beyley
Copy link
Member

@Beyley Beyley commented Aug 13, 2024

Adds a flag to all levels to state whether they contain modded content of any kind. Also adds a user setting + command to hide all modded content from the game, if the user does not wish to see any modded content in level results.

This PR also fixes MATT asset uploads and optimizes our realm migrations.

Beyley added 3 commits August 12, 2024 16:52
It's not an LBP asset, so we would return Unknown, Unknown before we even tried to special case MATT.
@Beyley Beyley requested a review from jvyden August 13, 2024 23:57
Copy link
Member

@jvyden jvyden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not gonna bother reviewing... Realm migration changes should be a different PR entirely.

And also, since we found levels flagged as modded despite being made of vanilla assets (e.g. the pod), this is prone to mis-flagging and I'm not sure we should be exposing the option to hide modded levels until we figure out a solution to that.

@Beyley
Copy link
Member Author

Beyley commented Aug 14, 2024

Marking as draft until I split the realm changes out to another PR

@Beyley Beyley marked this pull request as draft August 14, 2024 07:09
Beyley added 2 commits August 15, 2024 17:36
# Conflicts:
#	Refresh.GameServer/Database/GameDatabaseProvider.cs
@Beyley
Copy link
Member Author

Beyley commented Aug 16, 2024

Misflagging of vanilla assets has been solved. This PR also relaxes the mod filter slightly, as it has been discovered that a couple extra asset types can (very rarely) be uploaded by the game on an unmodified copy. After those changes, only ~10% of all levels on prod are marked as "modded", compared with the ~12% before those changes.

@Beyley Beyley marked this pull request as ready for review August 16, 2024 00:41
@Beyley Beyley requested a review from jvyden August 16, 2024 00:41
Refresh.GameServer/Database/GameDatabaseProvider.cs Outdated Show resolved Hide resolved
Refresh.GameServer/Importing/AssetImporter.cs Outdated Show resolved Hide resolved
Refresh.Common/Helpers/HexHelper.cs Outdated Show resolved Hide resolved
Refresh.Common/Helpers/HexHelper.cs Outdated Show resolved Hide resolved
Refresh.GameServer/Services/CommandService.cs Outdated Show resolved Hide resolved
Refresh.GameServer/Services/VanillaHashChecker.cs Outdated Show resolved Hide resolved
Refresh.GameServer/Services/VanillaHashChecker.cs Outdated Show resolved Hide resolved
Refresh.GameServer/Types/Levels/GameLevel.cs Outdated Show resolved Hide resolved
Refresh.GameServer/Extensions/LevelEnumerableExtensions.cs Outdated Show resolved Hide resolved
Beyley and others added 5 commits August 25, 2024 15:23
Copy link
Member

@jvyden jvyden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the state of where this is, so I'm gonna merge. Hopefully false-flags don't cause problems.

@jvyden jvyden merged commit 88d0e26 into LittleBigRefresh:main Aug 26, 2024
2 checks passed
@Beyley Beyley deleted the level-mod-filter branch August 27, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants