Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

Bump sprockets from 3.7.2 to 4.0.3 #1692

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 4, 2022

Bumps sprockets from 3.7.2 to 4.0.3.

Release notes

Sourced from sprockets's releases.

v4.0.3

What's Changed

New Contributors

Full Changelog: rails/sprockets@v4.0.2...v4.0.3

Changelog

Sourced from sprockets's changelog.

4.0.3

  • Fix Manifest#find yielding from a Promise causing issue on Ruby 3.1.0-dev. #720
  • Better detect the ERB version to avoid deprecation warnings. #719
  • Allow assets already fingerprinted to be served through Sprockets::Server
  • Do not fingerprint files that already contain a valid digest in their name
  • Remove remaining support for Ruby < 2.4.#672

4.0.2

  • Fix etag and digest path compilation that were generating string with invalid digest since 4.0.1.

4.0.1

  • Fix for Ruby 2.7 keyword arguments warning in base.rb. #660
  • Fix for when x_sprockets_linecount is missing from a source map.
  • Fix subresource integrity to match the digest of the asset.

4.0.0

  • Fixes for Ruby 2.7 keyword arguments warnings #625
  • Manifest files are sorted alphabetically #626

4.0.0.beta10

4.0.0.beta9

  • Minimum Ruby version for Sprockets 4 is now 2.5+ which matches minimum ruby version of Rails #604
  • Fix threading bug introduced in Sprockets 4 #603
  • Warn when two potential manifest files exist. #560

4.0.0.beta8

4.0.0.beta7

  • Fix a year long bug that caused Sprockets::FileNotFound errors when the asset was present #547
  • Raise an error when two assets such as foo.js and foo.js.erb would produce the same output artifact (foo.js) [📝 Updated cli documentation #549 #530]
  • Process *.jst.eco.erb files with ERBProcessor

4.0.0.beta6

  • Fix source map line offsets #515
  • Return a 400 Bad Request when the path encoding is invalid. #514

4.0.0.beta5

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Jul 4, 2022
@dependabot dependabot bot force-pushed the dependabot/bundler/sprockets-4.0.3 branch 4 times, most recently from 3ab9a60 to 35e0f59 Compare July 4, 2022 20:18
@itay1313 itay1313 closed this Jul 5, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 5, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/bundler/sprockets-4.0.3 branch July 5, 2022 12:14
@j9t j9t restored the dependabot/bundler/sprockets-4.0.3 branch July 6, 2022 08:18
@j9t
Copy link
Contributor

j9t commented Jul 6, 2022

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 6, 2022

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@j9t j9t reopened this Jul 6, 2022
@j9t j9t force-pushed the dependabot/bundler/sprockets-4.0.3 branch from 8f1bb9e to bb29a21 Compare July 6, 2022 08:19
@j9t
Copy link
Contributor

j9t commented Jul 6, 2022

@dependabot recreate

@dependabot dependabot bot force-pushed the dependabot/bundler/sprockets-4.0.3 branch from bb29a21 to 0574999 Compare July 6, 2022 10:07
@j9t j9t requested a review from itay1313 July 8, 2022 08:45
Copy link
Contributor

@itay1313 itay1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jekyll 3.9.2 | Error: wrong number of arguments (given 2, expected 1)

@j9t j9t force-pushed the dependabot/bundler/sprockets-4.0.3 branch from e4117d7 to 91afbbd Compare July 11, 2022 06:19
Bumps [sprockets](https://github.com/rails/sprockets) from 3.7.2 to 4.0.3.
- [Release notes](https://github.com/rails/sprockets/releases)
- [Changelog](https://github.com/rails/sprockets/blob/main/CHANGELOG.md)
- [Commits](rails/sprockets@v3.7.2...v4.0.3)

---
updated-dependencies:
- dependency-name: sprockets
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@j9t j9t force-pushed the dependabot/bundler/sprockets-4.0.3 branch from 91afbbd to f6006c3 Compare July 20, 2022 08:20
@itay1313
Copy link
Contributor

itay1313 commented Aug 8, 2022

@j9t checked, and this didnt work
jekyll 3.9.2 | Error: wrong number of arguments (given 2, expected 1)

@j9t
Copy link
Contributor

j9t commented Aug 8, 2022

Then we need to dive in and adjust the code accordingly. This is important but not urgent, so as long as we don’t accrue too many of these PRs this can wait a few days, and we can check on internal support if need be, too.

@itay1313 itay1313 closed this Sep 23, 2022
@dependabot dependabot bot deleted the dependabot/bundler/sprockets-4.0.3 branch September 23, 2022 15:53
@itay1313 itay1313 restored the dependabot/bundler/sprockets-4.0.3 branch September 27, 2022 07:30
@j9t
Copy link
Contributor

j9t commented Sep 27, 2022

@dependabot reopen

@dependabot dependabot bot reopened this Sep 27, 2022
@itay1313
Copy link
Contributor

@j9t there is a problem with this version of sprockets let's use older version and close this pr
https://stackoverflow.com/questions/60198057/jekyll-wrong-number-of-arguments-given-2-expected-1-argumenterror
image

image

@j9t
Copy link
Contributor

j9t commented Oct 18, 2022

@itay1313, see earlier notes—let’s keep everything open for which there is a newer version, so that we there’s visibility for it.

This issue here seems to exist for some time, so either we’re lucky and someone fixes this (either on the Jekyll or on the Sprockets side), or we bite the bullet and try to work around it, or bring this issue to either side’s attention (file a bug report with Jekyll or Sprockets).

If you want we can add a label for this. Don’t worry about it too much as long as we only have 1–3 of these requests, and keep an eye on it.

@itay1313 itay1313 added the fix needed fix issues with existing document label Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file do not merge fix needed fix issues with existing document ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants