Update Apple branding #1840
Update Apple branding #1840
Conversation
Replace Apple Business Chat and ABC with Apple Messages for Business and AMB, respectively.
|
@kstrickland09 Please resolve the conflicts, |
kstrickland09
force-pushed
the
master
branch
from
0c0b6a0 to
99689c1
Compare
Bumps [sprockets](https://github.com/rails/sprockets) from 3.7.2 to 4.0.3. - [Release notes](https://github.com/rails/sprockets/releases) - [Changelog](https://github.com/rails/sprockets/blob/main/CHANGELOG.md) - [Commits](rails/sprockets@v3.7.2...v4.0.3) --- updated-dependencies: - dependency-name: sprockets dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
|
@itay1313 I believe the conflicts are resolved now |
There was a problem hiding this comment.
Nice work, @kstrickland09.
We can negotiate on Markdown conversion but this is part of our content and style guide.
The redirects are important for UX and SEO.
Did you test the changes locally (just for context, would be helpful to know)?
pages/Documents/ConversationalAI/ConversationBuilder/BotTemplates/full-lead-gen.md
Outdated
Show resolved
Hide resolved
pages/Documents/ConversationalAI/ConversationBuilder/Interactions/configuration-next-action.md
Show resolved
Hide resolved
pages/Documents/MessagingChannels/AppleBusinessChatSDK/installation.md
Outdated
Show resolved
Hide resolved
pages/Documents/MessagingChannels/AppleBusinessChatSDK/overview.md
Outdated
Show resolved
Hide resolved
pages/Documents/RichMessaging/AppleBusinessChatTemplates/custom-interactive-message-template.md
Show resolved
Hide resolved
|
|
||
| #### Received Message Properties | ||
|
|
||
| <table> |
There was a problem hiding this comment.
I only edited this page -- can you help me understand how to translate it into markdown?
...uments/RichMessaging/StructuredContent/AppleBusinessChatTemplates/app-extensions-template.md
Outdated
Show resolved
Hide resolved
.../Documents/RichMessaging/StructuredContent/AppleBusinessChatTemplates/rich-links-template.md
Outdated
Show resolved
Hide resolved
pages/Documents/Security&Authentication/AppleBusinessChatAuthentication/overview.md
Outdated
Show resolved
Hide resolved
|
@itay1313, please take over during my absence. Consider having a look at the review comments for the main themes. Thanks! |
Thanks for fixing the conflicts, please review the new comments, let me know once they're fixed and I'll merge them |
…-4.0.3 chore(deps-dev): bump sprockets from 3.7.2 to 4.0.3
…elopers-community" This reverts commit 819b89d, reversing changes made to 0acc62e.
kstrickland09
force-pushed
the
master
branch
from
6b6e0aa to
16a08c8
Compare
|
@itay1313 It says I "force-pushed" changes so I want to make sure I didn't do something wrong. Can you verify? |
There was a problem hiding this comment.
@kstrickland09 please talk to me if you want, but a lot of important changes are being changed in this PR, please undo your last commit, maybe try to open a new PR with your changes, and close this one
| @@ -190,27 +190,10 @@ table>thead>tr>th { | |||
| border-bottom: none; | |||
| } | |||
|
|
|||
| table>tbody>tr:nth-of-type(odd):not(.categoryrow) td { | |||
There was a problem hiding this comment.
not good :) this is something we need so please take the latest version
| background-color: var(--table-cell); | ||
| } | ||
|
|
||
| #featurestable tr td, |
There was a problem hiding this comment.
also i need this, this was done in my latest pr, fixing to a responsive table
| @@ -3,108 +3,11 @@ pagename: Customizing the Conversational Cloud | |||
| sitesection: Documents | |||
| categoryname: "Getting Started" | |||
| permalink: customizing-the-conversational-cloud.html | |||
| redirect_from: | |||
There was a problem hiding this comment.
i believe you have a conflict here with @lkisoslive please take her latest version
| @@ -668,7 +668,7 @@ function searchFunction() { | |||
| //very similar to the search function above, just for the capabilities comparison table | |||
| function capabilitiesSearch() { | |||
| var $title = $(".h1").text() | |||
| if ($title.indexOf("Messaging features Capabilities Comparison") > -1) { | |||
There was a problem hiding this comment.
also, important, so please maybe undo last commit and merge with master
|
Hey please close this PR and open a new one with the changes you need. thanks, talk to me if you need help. |
Replace Business Chat and ABC with Messages for Business and AMB, respectively.