fix(input): correct touch dislocation #2893
Conversation
|
|
| this->env_width = ::platf::kms::env_monitors[monitor].width; | ||
| this->env_height = ::platf::kms::env_monitors[monitor].height; |
There was a problem hiding this comment.
Is there any risk with this breaking if we disconnect or add a monitor after sunshine was started? Can some id be used instead of index to improve safety?
There was a problem hiding this comment.
Functions that hanlle monitor change should take action to keep env_monitors updated, otherwise it might cause other issues.
|
@ReenigneArcher do you know someone that could test this? |
|
@Hazer Unfortunately, I don't. |
There was a problem hiding this comment.
I tested this locally on my Fedora 40 machine with a 3 screen configuration in GNOME. It seems to help (the mouse is on the correct screen now), but it's not a fully correct solution as the mouse cursor doesn't line up with where Moonlight expects it to be. You can see this if you run absolute mouse mode and press Ctrl+Alt+Shift+C to have both client and server cursors visible together.
|
ReenigneArcher
changed the title
Description
Fix touch dislocation on multiscreen devices
Screenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.