fix(packaging): ensure that uhid is loaded automatically

[gschintgen]

Description

There have been at least two reports of non-working DualSense5 emulation due to uhid not being loaded.

With this PR we'll configure systemd to automatically load uhid. (I suppose that currently it depends on the distribution and on which other devices the user may have connected to the host. I'm not sure.)

Do note that I'm rather new to CMake.

I did a few local tests (mainly a brief test that the uhid config is put in place correctly and that the module is loaded). I did not test rpm but since it shares the postinst with the .deb it should be fine.

• .deb
• .rpm
• Arch
• AppImage
• Flatpak

Screenshot

Issues Fixed or Closed

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update (updates to dependencies)
• Documentation update (changes to documentation)
• Repository update (changes to repository files, e.g. .github/...)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

• I want maintainers to keep my branch updated

[gschintgen]

Somehow I can no longer run the CI in my fork. It always fails at the Setup Release step:

ERROR: Squash and merge is not enabled for this repository. Please ensure ONLY squash and merge is enabled. DO NOT re-run this job after changing the repository settings. Wait until a new commit is made.

I then modified the settings in my repository according to the message but that did not work. (Probably because on my fork it's a branch and not a pull request.)

I don't know how to proceed to get this tested.

[ReenigneArcher]

Somehow I can no longer run the CI in my fork. It always fails at the Setup Release step:

ERROR: Squash and merge is not enabled for this repository. Please ensure ONLY squash and merge is enabled. DO NOT re-run this job after changing the repository settings. Wait until a new commit is made.

I then modified the settings in my repository according to the message but that did not work. (Probably because on my fork it's a branch and not a pull request.)

I don't know how to proceed to get this tested.

My suggestion is to create a PR into your master branch and run the CI that way.

[gschintgen]

My suggestion is to create a PR into your master branch and run the CI that way.

Ah, in hindsight that's kind of obvious. Thanks!

[ReenigneArcher]

There are some comments here we may want to investigate: #1720 (comment)

[ReenigneArcher]

This looks pretty good. I think rpm will be fine since it uses the same postinst as deb (excluding rpm-ostree OSes).

This could probably be merged once these few things are addressed, and rebased.

[ReenigneArcher]

I took this section out of the new docs, as all of our provided packages were taking care of this.

Maybe we should re-add it, but to the "building" section?

[gschintgen]

Maybe we should re-add it, but to the "building" section?

Yes, I think that's a good idea. Also, in the new docs, there is still the setcap step left, which could also be moved to the building section as it's taken care of by the regular (i.e. not flatpak or appimage) packages.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[ReenigneArcher]

FYI: #3041

[ReenigneArcher]

There were some updates related to this recently, I'm not sure if any of this is still needed?

[gschintgen]

There were some updates related to this recently, I'm not sure if any of this is still needed?

I'll have to (double) check but I'm unfortunately short on time. Yesterday, after distro-upgrading, I installed the latest published pre-release and quickly checked lsmod | grep uhid and uhid did show up. I planned on just leaving a comment here and closing my PR, but with the AMD PR still checked out I now don't have uhid loaded (and Sunshine is complaining about missing ds5 support).

[ReenigneArcher]

Okay, no problem. I'll mark this as draft for now.