fix(ddprobe): verifying frames should test up to 10 frames

[Nonary]

Description

Fixed a bug that caused the verify frame code to exit the loop early if it failed to acquire a frame (due to timeouts or other reasons).

It should now properly try up to 10 times.

Issues Fixed or Closed

N/A

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Dependency update (updates to dependencies)
• Documentation update (changes to documentation)
• Repository update (changes to repository files, e.g. .github/...)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.12%. Comparing base (d5854ae) to head (4260b52).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3414      +/-   ##
==========================================
- Coverage   11.13%   11.12%   -0.01%     
==========================================
  Files          99       99              
  Lines       17253    17253              
  Branches     8045     8045              
==========================================
- Hits         1921     1920       -1     
  Misses      12639    12639              
- Partials     2693     2694       +1     

Flag	Coverage Δ
Linux	8.37% <ø> (ø)
Windows	5.31% <ø> (ø)
macOS-13	13.62% <ø> (-0.02%)	⬇️
macOS-14	12.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[cgutman]

Does this mean in the worst case we're potentially waiting 5 seconds (500 ms * 10 tries) per invocation of ddprobe? That seems bad.

It already takes quite a while (like 30 seconds or so) to reprobe decoders when a display isn't connected due to ddprobe running over and over.