-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix /learn under redis database #410
Conversation
- Update learn command to include group chats for better functionality.
Add handling for NetworkError in receiver client for error reporting.
Add handling for NetworkError in receiver client for error reporting.
- Removed tiktoken and numpy dependencies - Updated requires-python to <3.12,>=3.9 in fast-langdetect - Updated content_hash in pdm.lock #comment This commit updates Python dependencies in pyproject.toml and pdm.lock files.
WalkthroughThe recent updates focus on enhancing bot functionalities and improving error handling across various modules. New commands like Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (2)
README.md (2)
Line range hint
154-154
: Fix the unpaired symbol in the Docker section.- Build Hub: [sudoskys/llmbot](https://hub.docker.com/repository/docker/sudoskys/llmbot/general) + Build Hub: [sudoskys/llmbot](https://hub.docker.com/repository/docker/sudoskys/llmbot/general)
Line range hint
81-84
: Fix the loose punctuation marks in the plugin development section.- `Login via url`: Use `/login <a token>$<something like https://provider.com/login>` to Login. The program posts the token to the interface to + `Login via url`: Use `/login <a token>$<something like https://provider.com/login>` to login. The program posts the token to the interface to - `Login`: Use `/login https://<api endpoint>/v1$<api key>$<the model>$<tool model such as gpt-3.5-turbo>` to login + `Login`: Use `/login https://<api endpoint>/v1$<api key>$<the model>$<tool model such as gpt-3.5-turbo>` to login.
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (2)
pdm.lock
is excluded by!**/*.lock
,!**/*.lock
pyproject.toml
is excluded by!**/*.toml
Files selected for processing (8)
- README.md (1 hunks)
- app/receiver/receiver_client.py (2 hunks)
- app/sender/telegram/init.py (1 hunks)
- docs/dev_note/tool_call_restart.md (1 hunks)
- llmkira/kv_manager/env.py (1 hunks)
- llmkira/kv_manager/instruction.py (2 hunks)
- llmkira/kv_manager/time.py (1 hunks)
- llmkira/kv_manager/tool_call.py (1 hunks)
Files skipped from review due to trivial changes (1)
- docs/dev_note/tool_call_restart.md
Additional comments not posted (12)
llmkira/kv_manager/tool_call.py (2)
Line range hint
14-23
: The implementation ofsave_toolcall
looks clean and well-documented.
35-36
: Good practice in handling byte-type data to ensure UTF-8 string processing.llmkira/kv_manager/instruction.py (2)
32-33
: Proper handling of byte-type data to ensure UTF-8 string processing.
Line range hint
37-43
: The implementation ofset_instruction
is straightforward and correctly handles type validation.llmkira/kv_manager/time.py (1)
35-36
: Proper handling of byte-type data to ensure UTF-8 string processing.llmkira/kv_manager/env.py (2)
Line range hint
25-29
: The implementation ofget_env
is straightforward and correctly retrieves environment variables.
42-43
: Proper handling of byte-type data to ensure UTF-8 string processing and good error logging practice.README.md (1)
179-187
: The list of slash commands is clear and comprehensive.app/receiver/receiver_client.py (3)
259-263
: Comprehensive error handling forNetworkError
with detailed logging.
Line range hint
300-400
: Detailed logging and error handling indeal_message
function.
Line range hint
500-600
: Effective message processing and error handling inon_message
function.app/sender/telegram/__init__.py (1)
230-232
: Support for multiple chat types inlearn
command enhances versatility.
No description provided.