Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Gear Code based fast equipment exchange for GemsFarming #3491

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Feature: Gear Code based fast equipment exchange for GemsFarming #3491

wants to merge 4 commits into from

Conversation

guoh064
Copy link
Contributor

@guoh064 guoh064 commented Feb 13, 2024 •
edited
Loading

Closes #3243

@guoh064 guoh064 force-pushed the gems_farming_gearcode branch from 9a6e2f7 to 4ba5979 Compare February 13, 2024 07:42
@guoh064 guoh064 marked this pull request as ready for review February 16, 2024 07:48
@guoh064 guoh064 force-pushed the gems_farming_gearcode branch 4 times, most recently from b2c1582 to 3c6603e Compare February 29, 2024 04:46
@GodofTheFallen
Copy link

目前已适配：

  • CN
  • EN
  • JP
  • TW

LmeSzinc
LmeSzinc reviewed Mar 20, 2024
View reviewed changes
Copy link
Owner

@LmeSzinc LmeSzinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议提取到当前装备码之后，写入到GemsFarming_EquipmentCode的对应字段里，供下次使用
所以实际功能的描述是：根据装备码换装备，未设置装备码时，提取当前装备码

assets/cn/equipment/EQUIPMENT_CODE_PAGE_CHECK.png Outdated Show resolved Hide resolved
module/equipment/equipment_code.py Outdated Show resolved Hide resolved
module/campaign/gems_farming.py Outdated Show resolved Hide resolved
module/equipment/equipment_code.py Outdated Show resolved Hide resolved
module/equipment/equipment_code.py Outdated Show resolved Hide resolved
@LmeSzinc LmeSzinc added the feature request / 功能请求 New feature or requests label Mar 20, 2024
@Air111

This comment has been minimized.

Sign in to view
@Air111

This comment was marked as outdated.

Sign in to view
@guoh064

This comment was marked as outdated.

Sign in to view
@Air111

This comment has been minimized.

Sign in to view
@guoh064
Copy link
Contributor Author

guoh064 commented Apr 17, 2024 •
edited
Loading

1a60ce9 重做了equipment_code.py、input.py和相关接口，主要改变如下：

  • 重构EquipmentCode类，只进行config的导入、修改、导出这三个功能；
  • 新建EquipmentCodeHandler类，为StorageHandler子类，包括在装备码界面的各种操作，目标是接替已有的EquipmentChange类完成装备替换。
    与此对应地，在gems_farming.py中：
  • 新建GemsEquipCodeHandler类，为EquipmentCodeHandler子类，指定了对应的更换船只和装备码设置位置。
  • 删除了原来使用的EquipmentChange类，并删除相关函数调用。

另外，在确认功能性没有问题后，后期计划将分支rebase到最新dev分支（或者dev分支merge到当前分支），以解决目前的合并冲突问题（需要 @LmeSzinc 的确认）

@guoh064 guoh064 requested a review from LmeSzinc April 17, 2024 00:24
Air111
Air111 reviewed Apr 18, 2024
View reviewed changes
module/equipment/equipment_code.py Outdated Show resolved Hide resolved
module/equipment/equipment_code.py Outdated Show resolved Hide resolved
@guoh064 guoh064 force-pushed the gems_farming_gearcode branch 6 times, most recently from 484b828 to 405c207 Compare April 23, 2024 03:52
@guoh064 guoh064 force-pushed the gems_farming_gearcode branch from 3407732 to bf6b603 Compare April 27, 2024 01:36
@guoh064 guoh064 force-pushed the gems_farming_gearcode branch from 86044c5 to 018be6b Compare May 24, 2024 08:16
This was referenced May 24, 2024
Merged
Open
@guoh064 guoh064 force-pushed the gems_farming_gearcode branch 3 times, most recently from 38f9144 to aa2e985 Compare June 26, 2024 11:32
@guoh064

This comment was marked as outdated.

Sign in to view
@guoh064 guoh064 force-pushed the gems_farming_gearcode branch from 9521385 to 62d5ff5 Compare August 29, 2024 05:39
@guoh064 guoh064 marked this pull request as draft September 13, 2024 15:38
@guoh064 guoh064 marked this pull request as ready for review September 14, 2024 09:13
@guoh064 guoh064 force-pushed the gems_farming_gearcode branch from 5a85286 to a7769e6 Compare December 12, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Air111 Air111 Air111 left review comments

@LmeSzinc LmeSzinc Awaiting requested review from LmeSzinc

Assignees
No one assigned
Labels
feature request / 功能请求 New feature or requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guoh064 @GodofTheFallen @Air111 @LmeSzinc