Skip to content
This repository has been archived by the owner on Mar 4, 2021. It is now read-only.

Commit

Permalink
Make javascript JavaScript and Github GitHub
Browse files Browse the repository at this point in the history
  • Loading branch information
jbrooksuk committed Jun 30, 2014
1 parent 28dd492 commit e139ab8
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/00-Getting-Started.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ First we need to include the Chart.js library on the page. The library occupies
<script src="Chart.js"></script>
```

Alternatively, if you're using an AMD loader for javascript modules, that is also supported in the Chart.js core. Please note: the library will still occupy a global variable of `Chart`, even if it detects `define` and `define.amd`. If this is a problem, you can call `noConflict` to restore the global Chart variable to it's previous owner.
Alternatively, if you're using an AMD loader for JavaScript modules, that is also supported in the Chart.js core. Please note: the library will still occupy a global variable of `Chart`, even if it detects `define` and `define.amd`. If this is a problem, you can call `noConflict` to restore the global Chart variable to it's previous owner.

```javascript
// Using requirejs
Expand Down
4 changes: 2 additions & 2 deletions docs/06-Advanced.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ new Chart(ctx).LineAlt(data);

### Creating custom builds

Chart.js uses <a href="http://gulpjs.com/" target="_blank">gulp</a> to build the library into a single javascript file. We can use this same build script with custom parameters in order to build a custom version.
Chart.js uses <a href="http://gulpjs.com/" target="_blank">gulp</a> to build the library into a single JavaScript file. We can use this same build script with custom parameters in order to build a custom version.

Firstly, we need to ensure development dependencies are installed. With node and npm installed, after cloning the Chart.js repo to a local directory, and navigating to that directory in the command line, we can run the following:

Expand All @@ -131,7 +131,7 @@ npm install
npm install -g gulp
```

This will install the local development dependencies for Chart.js, along with a CLI for the javascript task runner <a href="http://gulpjs.com/" target="_blank">gulp</a>.
This will install the local development dependencies for Chart.js, along with a CLI for the JavaScript task runner <a href="http://gulpjs.com/" target="_blank">gulp</a>.

Now, we can run the `gulp build` task, and pass in a comma seperated list of types as an argument to build a custom version of Chart.js with only specified chart types.

Expand Down
2 changes: 1 addition & 1 deletion docs/07-Notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Some important points to note in my experience using ExplorerCanvas as a fallbac

### Bugs & issues

Please report these on the Github page - at <a href="https://github.com/nnnick/Chart.js" target="_blank">github.com/nnnick/Chart.js</a>. If you could include a link to a simple <a href="http://jsbin.com/" target="_blank">jsbin</a> or similar to demonstrate the issue, that'd be really helpful.
Please report these on the GitHub page - at <a href="https://github.com/nnnick/Chart.js" target="_blank">github.com/nnnick/Chart.js</a>. If you could include a link to a simple <a href="http://jsbin.com/" target="_blank">jsbin</a> or similar to demonstrate the issue, that'd be really helpful.


### Contributing
Expand Down

0 comments on commit e139ab8

Please sign in to comment.