Migrate from System.Drawing.Bitmap #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the majority of Bitmap references, replacing with SixLabors.Image instead. This is only used internally in TRImage. The core library continues to use bitmaps for specific drawing techniques.
This moves the tests that were previously in ImageControl and LevelControl into a randomizer core specific test library.
WEBP, JPG and GIF now supported, if ever needed.
Replacement drawing methods are now provided in TRImage, courtesy of ImageSharp. This allows us to remove the final few bitmap references.
No projects have Windows-only dependencies now, bar the UI but that's a given.
This was Windows only too because it uses TRDataControl.
rr-
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #522.
Checklist
Description
We use
SixLabors.ImageSharpnow in place of bitmaps, and in turn no project in the solution (other than the UI) is Windows-only.TRImagecontinues to hide implementation details butToImage()can be used to return anImageSharpobject if advanced editing is needed. The new wrapper drawing methods are not hugely efficient (convert toImageSharp=> draw => convert back) but these are only used in wireframing and in the room face export tool. They can maybe be further optimised in the future.I've also split the
TRImageclass out to keep similar methods together for easier reference.