Fix absalon flowers #2426
Merged
Fix absalon flowers #2426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first PR changed the biome modifiers that place the flowers to prevent a crash with mods like Terralith and Regions Unexplored.
I didn't notice this at first, but the
absalonbiome modifier placed the lime flowers and thelimebiome modifier placed the absalon flowers. My second PR only fixed one of these discrepancies, so both theabsalonandlimebiome modifiers started placing lime flowers, which was a guaranteed crash. Sorry about that!This PR makes the
absalonbiome modifier place absalon flowers, and now everything should be fixed.Fixes #2421, #2422, and #2424.