Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.1] A few small bug fixes #2456

Merged
merged 6 commits into from
Jan 7, 2025
Merged

Conversation

Gegy
Copy link
Contributor

@Gegy Gegy commented Jan 1, 2025

This PR is a collection of a few small but random fixes to bugs we noticed while playing with Cyclic on a server - I thought it makes more sense to just make one PR than a bunch of tiny ones, but happy to split it up if that is preferred!

Particularly, the last commit addresses an inconsistency with Mattocks in Miners - but I'm not sure how it is supposed to behave by design. If this needs some more thought especially, I can move that out or drop the commit 🙂

Also not sure if the 1.20.1 branch is the right one to PR to - but if not, am happy to rebase it :)

The bugs addressed:

  • If a Miner fails to harvest a block (in our case, mining an instanced loot chest from Lootr), it would destroy itself. This seems to have been a mistake in the fallback case when the target fails to be mined, forcing the break on itself rather than the target. Might relate to Miner destroys itself while in a claimed chunk #2367?
  • Fluid Collectors when unloaded would lose their size/height settings (unlike Miners)
  • Miners when unloaded would lose their current mined progress (unlike Fluid Collectors)
  • The client would crash when trying to render a shapedata block preview without both targets set
  • Items in cables could be pushed against an extraction cable in the fallback case where they could not travel anywhere else - this could rarely lead to output items ending up back in input slots in an unexpected way
  • Mattocks behave inconsistently when used in a Miner block - as the fake player is placed at the corner of the Miner, the distance and whether in the negative/negative quadrant relative to the Miner would affect whether it applies

@Lothrazar Lothrazar self-assigned this Jan 5, 2025
@Lothrazar Lothrazar merged commit 8dc2b37 into Lothrazar:trunk/1.20.1 Jan 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants