Don't clear command_args in openrc #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For one, we were not using any arguments, so the variable was unnecessary. More importantly, that variable should probably be set by the user, in /etc/conf.d/avahi2dns, as documented in https://wiki.gentoo.org/wiki/Handbook:X86/Working/Initscripts#conf.d_directory With this I was able to document a way to get printer discovery working on alpine: https://wiki.alpinelinux.org/wiki/MDNS
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For one, we were not using any arguments, so the variable was unnecessary.
More importantly, that variable should probably be set by the user, in /etc/conf.d/avahi2dns, as documented in
https://wiki.gentoo.org/wiki/Handbook:X86/Working/Initscripts#conf.d_directory
With this I was able to document a way to get printer discovery working on alpine:
https://wiki.alpinelinux.org/wiki/MDNS