Fix potential memory leak

src/hotplug_macosx.c:594:4 Potential leak of an object stored into 'valueRef'
LudovicRousseau · May 6, 2024 · dfa0690 · dfa0690
1 parent 11a48a0
commit dfa0690
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/hotplug_macosx.c b/src/hotplug_macosx.c
@@ -568,6 +568,7 @@ HPDriversMatchPCCardDevices(HPDriver * driverBundle,
 		{
 			CFNumberGetValue((CFNumberRef) valueRef, kCFNumberSInt32Type,
 				&vendorId);
+			CFRelease(valueRef);
 		}
 		valueRef =
 			IORegistryEntryCreateCFProperty(pccDevice, CFSTR("DeviceID"),
@@ -580,6 +581,7 @@ HPDriversMatchPCCardDevices(HPDriver * driverBundle,
 		{
 			CFNumberGetValue((CFNumberRef) valueRef, kCFNumberSInt32Type,
 				&productId);
+			CFRelease(valueRef);
 		}
 		valueRef =
 			IORegistryEntryCreateCFProperty(pccDevice, CFSTR("SocketNumber"),
@@ -592,6 +594,7 @@ HPDriversMatchPCCardDevices(HPDriver * driverBundle,
 		{
 			CFNumberGetValue((CFNumberRef) valueRef, kCFNumberSInt32Type,
 				&pccAddress);
+			CFRelease(valueRef);
 		}
 		HPDriver *driver = driverBundle;