Skip to content

Commit

Permalink
fix: Disable default features for server SDK's dependencies (#386)
Browse files Browse the repository at this point in the history
  • Loading branch information
LukeMathWalker authored Dec 1, 2024
1 parent 0888ea7 commit f17ba82
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions libs/pavexc/src/compiler/codegen/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,14 @@ where
let version = metadata.version();
let mut dependency_details = DependencyDetail {
version: Some(version.to_string()),
// We disable default features to avoid enabling by mistake
// features that were explicitly disabled in the app manifest.
// This is a conservative choice, but it's better to be safe than sorry.
// We can use a more fine-grained approach in the future if needed, e.g. by
// analyzing which features are actually used in the code.
// Until then, we rely on feature unification to ensure everything works as expected
// in the final binary.
default_features: Some(false),
..DependencyDetail::default()
};
if needs_rename {
Expand Down

0 comments on commit f17ba82

Please sign in to comment.