Handle ItemEnum kind case where function is a method

[donmai-me]

While reading how Pavex works I found this todo that's low hanging. Using the fact that self is a reserved keyword and only appears as the first parameter in a method.

Hope it's ok that I don't put my real name in CONTRIBUTORS.md. Love your book btw thanks!

[LukeMathWalker]

While reading how Pavex works I found this todo that's low hanging. Using the fact that self is a reserved keyword and only appears as the first parameter in a method.

That's a good heuristic!
Does it work even if the function takes &self/&mut self? It'd be ideal to have a test covering this.

Hope it's ok that I don't put my real name in CONTRIBUTORS.md. Love your book btw thanks!

That's fine!

[donmai-me]

Does it work even if the function takes &self/&mut self? It'd be ideal to have a test covering this.

Yes only the type of self changes. I used this sample code

use std::pin::Pin;

pub struct Foo {
    bar: u32,
}

impl Foo {
    pub fn new(bar: u32) -> Self {
        Self { bar }
    }

    pub fn self_ref(&self) {
        println!("self_ref: {}", self.bar);
    }

    pub fn self_mut_ref(&mut self) {
        println!("self_mut_ref: {}", self.bar);
    }

    pub fn self_take(self) {
        println!("self_take: {}", self.bar);
    }

    pub fn self_take_box(self: Box<Self>) {
        println!("self_take_box: {}", self.bar);
    }

    pub fn self_pin_ref(self: Pin<&Self>) {
        println!("self_pin_ref: {}", self.bar);
    }
}

and the rustdoc generated the following inputs for the methods

"inputs":[["self",{"borrowed_ref":{"lifetime":null,"is_mutable":false,"type":{"generic":"Self"}}}]]
...
"inputs":[["self",{"borrowed_ref":{"lifetime":null,"is_mutable":true,"type":{"generic":"Self"}}}]]
...
"inputs":[["self",{"generic":"Self"}]]
...
"inputs":[["self",{"resolved_path":{"name":"Box","id":"5:324:2510","args":{"angle_bracketed":{"args":[{"type":{"generic":"Self"}}]
...
"inputs":[["self",{"resolved_path":{"name":"Pin","id":"2:37066:2499","args":{"angle_bracketed":{"args":[{"type":{"borrowed_ref":{"lifetime":null,"is_mutable":false,"type":{"generic":"Self"}}}}]

I don't exactly know how to do a test that would call rustdoc and check the json output, and how to make it fit with the rest of pavex's tests. If you can give some guidance that would be appreciated.

[LukeMathWalker]

It'd be a bit contrived for this specific case, so we can skip it. Nice to see that it works for more complex self types too, such as Box and Pin!

[LukeMathWalker]

/ok-to-test sha=31601ab