Implement maimai judgement modes in HardRock #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This along with Gori mod is now within the HR mod
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #485
This ports over the judgement modes present in maimai (Maji, Gachi) which shifts the HitWindow ranges to be more challenging, this replaces the existing HR implementation, as both affected HitWindows.
Gori mode (where any non-perfect windows are ignored) is implemented as a separate drop-down to allow players to use it with any of the judgement modes, rather than a predefined one. On top of that players are able to select the minimum accepted HitResult, allowing for more fine-tuning of challenge.