Draw slide chevrons using SDF shader #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a more flexible chevron drawable that avoids the buffered container, might as well use it.
Reduces the jaggies
Better aligns the edges with the dots
LumpBloom7
added
tweak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both FanSlide chevrons and regular slides are affected by this change.
Regular slide chevrons now sport rounded edges, matching other gameplay hitobjects and the fan slide.
With the use of the same
DrawableChevron, the code to generate fan slide chevrons is greatly simplified.SlideFanChevronsare no longer created at theDrawableRuleset, and the use ofBufferedContainerViewsare also not needed. Fan Chevron visuals remain nearly identical.A side effect of this change is that the chevrons support the same glow that exists for the laned notes, opening up the potential for something like an "EX Slide".