Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repo: Remove Vulkan-Layer-Factory #1847

Merged
merged 2 commits into from
Aug 15, 2023
Merged

repo: Remove Vulkan-Layer-Factory #1847

merged 2 commits into from
Aug 15, 2023

Conversation

charles-lunarg
Copy link
Contributor

The Vulkan-Layer-Factory project is being moved into its own repo for archival purposes. This commit removes it from this repo as well as documents where the archival repo is.

Repo is available here: https://github.com/LunarG/Vulkan-Layer-Factory

@ci-tester-lunarg
Copy link

CI VulkanTools build queued with queue ID 23498.

@ci-tester-lunarg
Copy link

CI VulkanTools build # 2618 running.

@charles-lunarg charles-lunarg linked an issue Aug 14, 2023 that may be closed by this pull request
Move LayerFactory code into a standlone read only repo #1822
Closed
@ci-tester-lunarg
Copy link

CI VulkanTools build queued with queue ID 23506.

@charles-lunarg charles-lunarg changed the title repo: Remove Vulkan-Layer-Factory from source repo: Remove Vulkan-Layer-Factory Aug 14, 2023
@ci-tester-lunarg
Copy link

CI VulkanTools build # 2619 running.

@ci-tester-lunarg
Copy link

CI VulkanTools build queued with queue ID 23527.

@ci-tester-lunarg
Copy link

CI VulkanTools build # 2620 running.

juan-lunarg
juan-lunarg reviewed Aug 14, 2023
View reviewed changes
Copy link
Contributor

@juan-lunarg juan-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is mention of VLF in the vulkan validation layers (In particular the integration testing. Ideally that is cleaned up as well).

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ci-tester-lunarg
Copy link

CI VulkanTools build # 2620 failed.

@charles-lunarg
repo: Remove Vulkan-Layer-Factory
17d634a 
The Vulkan-Layer-Factory project is being moved into its own repo for
archival purposes. This commit removes it from this repo as well as
documents where the archival repo is.
@charles-lunarg
docs: Update Readme
e2644de 
Remove notification of default branch change & CI status badges from the readme.
@charles-lunarg
Copy link
Contributor Author

Internal CI is failing due to having hardcoded references to the VLF layers. Not sure what the path forward is here - need to determine just how much they are used in internal CI.

@ci-tester-lunarg
Copy link

CI VulkanTools build queued with queue ID 23554.

@ci-tester-lunarg
Copy link

CI VulkanTools build # 2621 running.

@ci-tester-lunarg
Copy link

CI VulkanTools build # 2621 failed.

@charles-lunarg
Copy link
Contributor Author

Not sure why the ci bot didn't say anything, but the issue causing internal ci to fail has been resolved and there was a successful run of internal CI, so I'm going to go ahead and merge.

@charles-lunarg charles-lunarg merged commit 02b198f into LunarG:main Aug 15, 2023
7 checks passed
@charles-lunarg charles-lunarg deleted the remove_vlf branch August 15, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan-lunarg juan-lunarg juan-lunarg approved these changes

@TonyBarbour TonyBarbour Awaiting requested review from TonyBarbour

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move LayerFactory code into a standlone read only repo
3 participants
@charles-lunarg @ci-tester-lunarg @juan-lunarg