minor cmake cleanup #1852
Merged
minor cmake cleanup #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove USE_CCACHE Remove CMAKE_OSX_DEPLOYMENT_TARGET Remove FALLBACK_CONFIG_DIRS / FALLBACK_DATA_DIRS Properly set enable_testing()
|
CI VulkanTools build queued with queue ID 25980. |
|
CI VulkanTools build # 2633 running. |
juan-lunarg
commented
Aug 18, 2023
Comment on lines
-107
to
-111
| set(FALLBACK_CONFIG_DIRS "/etc/xdg" CACHE STRING | ||
| "Search path to use when XDG_CONFIG_DIRS is unset or empty or the current process is SUID/SGID. Default is freedesktop compliant.") | ||
| set(FALLBACK_DATA_DIRS "/usr/local/share:/usr/share" CACHE STRING | ||
| "Search path to use when XDG_DATA_DIRS is unset or empty or the current process is SUID/SGID. Default is freedesktop compliant.") | ||
|
|
There was a problem hiding this comment.
Didn't see these used anywhere. Looks like copy paste from the loader.
|
CI VulkanTools build # 2633 passed. |
charles-lunarg
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.