Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove build-android #1872

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Remove build-android #1872

merged 3 commits into from
Aug 25, 2023

Conversation

juan-lunarg
Copy link
Contributor

closes #1850

Ensure CMAKE_POSITION_INDEPENDENT_CODE is set uniformly
Ensure VISIBILITY is set uniformly
Ensure beta extensions and android definitions are set uniformly

Needed to ensure the Android builds are on parity with the
removed ndk-build
@ci-tester-lunarg
Copy link

CI VulkanTools build queued with queue ID 30668.

@ci-tester-lunarg
Copy link

CI VulkanTools build # 2677 running.

Copy link
Contributor

@charles-lunarg charles-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love removing code!

@ci-tester-lunarg
Copy link

CI VulkanTools build # 2677 passed.

@juan-lunarg juan-lunarg merged commit f45dbf4 into LunarG:main Aug 25, 2023
6 checks passed
@juan-lunarg juan-lunarg deleted the juan/build-android branch August 25, 2023 19:07
@juan-lunarg
Copy link
Contributor Author

FYI @christophe-lunarg we can now add the utility libraries to this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS - Android Android specific bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android build is frozen due to changes in VVL Android build
3 participants