Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Remove VVL as a dependency #1883

Merged
merged 1 commit into from
Sep 11, 2023
Merged

build: Remove VVL as a dependency #1883

merged 1 commit into from
Sep 11, 2023

Conversation

juan-lunarg
Copy link
Contributor

@juan-lunarg juan-lunarg commented Sep 4, 2023 •
edited
Loading

No description provided.

@ci-tester-lunarg
Copy link

CI VulkanTools build queued with queue ID 36429.

@ci-tester-lunarg
Copy link

CI VulkanTools build queued with queue ID 36434.

@ci-tester-lunarg
Copy link

CI VulkanTools build # 2701 running.

@ci-tester-lunarg
Copy link

CI VulkanTools build queued with queue ID 36441.

@ci-tester-lunarg
Copy link

CI VulkanTools build # 2702 running.

juan-lunarg
juan-lunarg commented Sep 4, 2023
View reviewed changes
layersvt/api_dump.h Outdated Show resolved Hide resolved
@ci-tester-lunarg
Copy link

CI VulkanTools build # 2702 failed.

@juan-lunarg juan-lunarg mentioned this pull request Sep 4, 2023
Merged
@ci-tester-lunarg
Copy link

CI VulkanTools build queued with queue ID 38101.

@ci-tester-lunarg
Copy link

CI VulkanTools build queued with queue ID 38106.

@ci-tester-lunarg
Copy link

CI VulkanTools build # 2720 running.

@ci-tester-lunarg
Copy link

CI VulkanTools build queued with queue ID 38113.

@ci-tester-lunarg
Copy link

CI VulkanTools build # 2721 running.

@ci-tester-lunarg
Copy link

CI VulkanTools build # 2721 failed.

christophe-lunarg
christophe-lunarg approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@christophe-lunarg christophe-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@ci-tester-lunarg
Copy link

CI VulkanTools build queued with queue ID 40172.

@ci-tester-lunarg
Copy link

CI VulkanTools build # 2724 running.

@ci-tester-lunarg
Copy link

CI VulkanTools build # 2724 passed.

@ci-tester-lunarg
Copy link

CI VulkanTools build queued with queue ID 40261.

@juan-lunarg juan-lunarg marked this pull request as ready for review September 11, 2023 19:03
@ci-tester-lunarg
Copy link

CI VulkanTools build # 2725 running.

charles-lunarg
charles-lunarg approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@charles-lunarg charles-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ci-tester-lunarg
Copy link

CI VulkanTools build # 2725 failed.

@ci-tester-lunarg
Copy link

CI VulkanTools build queued with queue ID 40304.

@ci-tester-lunarg
Copy link

CI VulkanTools build # 2726 running.

@ci-tester-lunarg
Copy link

CI VulkanTools build # 2726 passed.

@juan-lunarg juan-lunarg merged commit 8127db8 into LunarG:main Sep 11, 2023
6 checks passed
@juan-lunarg juan-lunarg deleted the juan/remove_vvl_from_tools branch September 11, 2023 20:35
@juan-lunarg
Copy link
Contributor Author

This repo builds a LOT faster now. Same goes for the CI. VVL took up quite a bit of time.

@juan-lunarg juan-lunarg mentioned this pull request Sep 11, 2023
Merged
juan-lunarg added a commit to KhronosGroup/Vulkan-ValidationLayers that referenced this pull request Sep 12, 2023
@juan-lunarg
cmake: Remove BUILD_LAYER_SUPPORT_FILES
7e26128 
LunarG/VulkanTools no longer depends on the validation layers.

See LunarG/VulkanTools#1883

BUILD_LAYERS and BUILD_LAYER_SUPPORT_FILES are removed as they
are no longer needed.

The corresponding integration tests are also no longer needed.

closes #6246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophe-lunarg christophe-lunarg christophe-lunarg approved these changes

@charles-lunarg charles-lunarg charles-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juan-lunarg @ci-tester-lunarg @charles-lunarg @christophe-lunarg