discard-cached-psos renamed to use_cached_psos #1207
Conversation
|
CI gfxreconstruct build queued with queue ID 9704. |
|
CI gfxreconstruct build # 3006 running. |
|
CI gfxreconstruct build # 3006 passed. |
|
In general I think this is fine, probably "dcp" should be the default. However, "dcp" means "discard cached PSOs". "enable-dcp" would mean "enable discard cached PSOs", the same thing as "dcp". If this change makes "discard cached PSOs" the default and adds an option to not discard the PSOs, then I think the option would be called "use-cached-psos" or some such. |
igorbrsn
force-pushed
the
dev-enable-discard-cached-psos
branch
from
03a98d4
to
1cd2efa
Compare
|
CI gfxreconstruct build queued with queue ID 9807. |
Changed to --use-cached-psos |
|
CI gfxreconstruct build # 3009 running. |
|
CI gfxreconstruct build queued with queue ID 9836. |
|
CI gfxreconstruct build # 3010 running. |
|
CI gfxreconstruct build # 3010 passed. |
I am updating logic |
|
CI gfxreconstruct build queued with queue ID 14098. |
|
CI gfxreconstruct build # 3033 running. |
|
CI gfxreconstruct build # 3033 failed. |
tools/tool_settings.h
Outdated
| @@ -805,7 +806,14 @@ static gfxrecon::decode::DxReplayOptions GetDxReplayOptions(const gfxrecon::util | |||
|
|
|||
| if (arg_parser.IsOptionSet(kDiscardCachedPsosLongOption) || arg_parser.IsOptionSet(kDiscardCachedPsosShortOption)) | |||
| { | |||
| replay_options.discard_cached_psos = true; | |||
| GFXRECON_LOG_WARNING("The parameters --dcp and --discard-cached-psos have been depracated in favor for " | |||
USAGE_desktop_D3D12.md
Outdated
| @@ -183,7 +183,7 @@ Usage: | |||
| [--screenshot-dir <dir>] [--screenshot-prefix <file-prefix>] | |||
| [--sfa | --skip-failed-allocations] [--replace-shaders <dir>] | |||
| [--opcd | --omit-pipeline-cache-data] [--wsi <platform>] | |||
| [--dcp | --discard-cached-psos] [--surface-index <N>] | |||
| [--use-cached-psos <boolean>] [--surface-index <N>] | |||
There was a problem hiding this comment.
I think it shouldn't be a boolean if it's off if you specify nothing but turned on when you specify it. Making this a boolean would make it inconsistent with other command-line switches.
| @@ -2207,7 +2207,7 @@ HRESULT Dx12ReplayConsumerBase::OverrideLoadGraphicsPipeline( | |||
| (desc != nullptr) && (desc->GetPointer() != nullptr) && (state != nullptr)); | |||
|
|
|||
| auto desc2 = desc->GetPointer(); | |||
| if (options_.discard_cached_psos) | |||
| if (options_.use_cached_psos == false) | |||
There was a problem hiding this comment.
I prefer !options_.use_cached_psos to checking for explicit false.
|
CI gfxreconstruct build queued with queue ID 15327. |
|
CI gfxreconstruct build # 3039 running. |
|
CI gfxreconstruct build # 3039 passed. |
|
CI gfxreconstruct build queued with queue ID 15471. |
igorbrsn
changed the title
|
CI gfxreconstruct build # 3042 running. |
|
CI gfxreconstruct build # 3042 passed. |
Problem:
The replayer should always use 'discard-cached-psos'. Currently '--dcp' and '--discard-cached-psos' are options and could not be disabled.
Solution:
Added option'--use-cached-psos' with default 'false'. 'discard_cached_psos' renamed to 'use_cached_psos' and would be set 'true' if used.
Test:
Tested with default, enabled and disabled. Warning issued when deprecated '--dcp' is used.