Complete ExeFileInfo json consumer path for Vulkan and D3D12 #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 185821. |
|
CI gfxreconstruct build # 4162 running. |
beau-lunarg
force-pushed
the
beau-fix-1336
branch
from
a1ce457 to
976ec0f
Compare
|
CI gfxreconstruct build queued with queue ID 185853. |
beau-lunarg
force-pushed
the
beau-fix-1336
branch
from
976ec0f to
8e59703
Compare
|
CI gfxreconstruct build queued with queue ID 185854. |
beau-lunarg
force-pushed
the
beau-fix-1336
branch
from
8e59703 to
69c01f3
Compare
|
CI gfxreconstruct build queued with queue ID 185887. |
beau-lunarg
force-pushed
the
beau-fix-1336
branch
from
69c01f3 to
22a7ce5
Compare
|
CI gfxreconstruct build queued with queue ID 185904. |
|
CI gfxreconstruct build # 4166 running. |
|
CI gfxreconstruct build # 4166 passed. |
|
CI gfxreconstruct build queued with queue ID 186715. |
|
CI gfxreconstruct build # 4190 running. |
|
CI gfxreconstruct build # 4190 passed. |
|
CI gfxreconstruct build queued with queue ID 187121. |
|
CI gfxreconstruct build queued with queue ID 187132. |
Move the base definition to the MetadataConsumerBase, since its metadata. Single implementation in MetadataJsonConsumer, including removing old implementation in dx12_json_consumer. Single implementation writes each field individually instead of passing the full struct. This means that if the struct changes in the future, that won't cause backwards compatibility issues.kk
beau-lunarg
force-pushed
the
beau-fix-1336
branch
from
41ed89a to
f13ff8c
Compare
|
CI gfxreconstruct build queued with queue ID 187147. |
|
CI gfxreconstruct build # 187147 cancelled. |
|
CI gfxreconstruct build queued with queue ID 187457. |
|
CI gfxreconstruct build # 4200 running. |
|
CI gfxreconstruct build queued with queue ID 187471. |
|
CI gfxreconstruct build # 4201 running. |
|
CI gfxreconstruct build # 4201 passed. |
bradgrantham-lunarg
approved these changes
May 20, 2024
locke-lunarg
pushed a commit
to locke-lunarg/gfxreconstruct
that referenced
this pull request
Jun 10, 2024
…1550) * Complete ExeFileInfo json consumer path for Vulkan and D3D12 * Regenerate DX12 files * Standardize Process_ExeFileInfo location and definition Move the base definition to the MetadataConsumerBase, since its metadata. Single implementation in MetadataJsonConsumer, including removing old implementation in dx12_json_consumer. Single implementation writes each field individually instead of passing the full struct. This means that if the struct changes in the future, that won't cause backwards compatibility issues.kk * Fix SDK numbers * Remove duplicate Process_ExeFileInfo * Determine if decoder supports metadataid before dispatching exe file info * Fix formatting
locke-lunarg
pushed a commit
to locke-lunarg/gfxreconstruct
that referenced
this pull request
Jun 10, 2024
…1550) * Complete ExeFileInfo json consumer path for Vulkan and D3D12 * Regenerate DX12 files * Standardize Process_ExeFileInfo location and definition Move the base definition to the MetadataConsumerBase, since its metadata. Single implementation in MetadataJsonConsumer, including removing old implementation in dx12_json_consumer. Single implementation writes each field individually instead of passing the full struct. This means that if the struct changes in the future, that won't cause backwards compatibility issues.kk * Fix SDK numbers * Remove duplicate Process_ExeFileInfo * Determine if decoder supports metadataid before dispatching exe file info * Fix formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1336