Add DX12 code generation out-of-date check to the GitHub CI build #1556
Conversation
|
CI gfxreconstruct build queued with queue ID 186129. |
|
CI gfxreconstruct build queued with queue ID 186171. |
|
CI gfxreconstruct build queued with queue ID 186262. |
|
CI gfxreconstruct build # 4180 running. |
|
CI gfxreconstruct build # 4180 passed. |
|
CI gfxreconstruct build queued with queue ID 187144. |
|
CI gfxreconstruct build # 4197 running. |
|
CI gfxreconstruct build # 4197 passed. |
|
CI gfxreconstruct build queued with queue ID 187526. |
|
CI gfxreconstruct build queued with queue ID 187537. |
|
CI gfxreconstruct build queued with queue ID 187539. |
|
CI gfxreconstruct build queued with queue ID 187560. |
|
CI gfxreconstruct build queued with queue ID 187562. |
|
CI gfxreconstruct build queued with queue ID 187577. |
|
CI gfxreconstruct build queued with queue ID 187579. |
|
CI gfxreconstruct build queued with queue ID 187584. |
|
CI gfxreconstruct build queued with queue ID 187599. |
|
CI gfxreconstruct build queued with queue ID 187600. |
|
CI gfxreconstruct build queued with queue ID 187606. |
|
CI gfxreconstruct build queued with queue ID 187607. |
|
CI gfxreconstruct build queued with queue ID 187620. |
|
CI gfxreconstruct build queued with queue ID 187624. |
|
CI gfxreconstruct build # 187624 cancelled. |
|
CI gfxreconstruct build queued with queue ID 187626. |
|
CI gfxreconstruct build # 187626 cancelled. |
|
CI gfxreconstruct build queued with queue ID 187628. |
|
CI gfxreconstruct build queued with queue ID 187639. |
|
CI gfxreconstruct build # 4208 running. |
|
CI gfxreconstruct build # 4208 aborted. |
|
CI gfxreconstruct build queued with queue ID 187656. |
|
CI gfxreconstruct build # 4210 aborted. |
set VCVars and skip build temporarily
bradgrantham-lunarg
force-pushed
the
github-ci-generate-dx12
branch
from
11a6482 to
4431b13
Compare
|
CI gfxreconstruct build queued with queue ID 187687. |
|
CI gfxreconstruct build # 4211 running. |
|
CI gfxreconstruct build # 4211 aborted. |
bradgrantham-lunarg
requested review from
mikes-lunarg and
davidd-lunarg
and removed request for
mikes-lunarg
bradgrantham-lunarg
changed the title
.github/workflows/ci_build.yml
Outdated
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.10' | ||
| # cache: 'pip' # caching pip dependencies |
There was a problem hiding this comment.
did the cache option not work?
There was a problem hiding this comment.
With the cache line in there I got this error:
Run actions/setup-python@v5
Installed versions
Error: No file in D:\a\gfxreconstruct\gfxreconstruct matched to [**/requirements.txt or **/pyproject.toml], make sure you have checked out the target repository
I'll take out the cache line.
There was a problem hiding this comment.
Ah ok. From the docs I it looks like they expect a requirements file so they can hash and use it as a cache key: https://github.com/actions/setup-python?tab=readme-ov-file#caching-packages-dependencies
Then you would call pip with pip install -r requirements.txt. That would let you version-lock your python dependencies and invalidate the cache when they get updated.
There was a problem hiding this comment.
Looks like the pip install only takes 10-20 seconds of a 10 minute job, so caching is probably overkill anyway!
There was a problem hiding this comment.
Just running the generators required SO MANY dependencies (and I discovered each one after waiting 15 minutes for the CI build to run) that I just didn't care enough to enable caching. Thank you for doing the footwork to figure out how I would reintroduce the cache!
|
CI gfxreconstruct build queued with queue ID 190008. |
|
CI gfxreconstruct build # 4234 running. |
|
CI gfxreconstruct build # 4234 passed. |
…narG#1556) * add DX12 code generation to the GitHub CI build * use ilemmy's vsdevcmd action * require Python 3.10 * require ply * use SDK 20348 * set VCVars * checkout before building * set Windows SDK Version * update tree before generated code check * diff merge ref; use recursive checkout
…narG#1556) * add DX12 code generation to the GitHub CI build * use ilemmy's vsdevcmd action * require Python 3.10 * require ply * use SDK 20348 * set VCVars * checkout before building * set Windows SDK Version * update tree before generated code check * diff merge ref; use recursive checkout
No description provided.