Do second round API detect for optimizer if needed #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem For some cases, 1000 blocks is not enough for API detection. Solution If the first round detection with 1000 blocks doesn't return any detection result, we will do a second round API detection with no-block-limit parameter. The detection will be done with no block limit, till one of targeted API calls is found. A message will show in the console if the second round is needed. Result It looks for most cases, 1000 blocks should be enough for the API detection. The second round detection should always give us the result and it will be performed only the first round detection (short) doesn't provide any result.
|
CI gfxreconstruct build queued with queue ID 186720. |
|
CI gfxreconstruct build # 4191 running. |
|
CI gfxreconstruct build # 4191 passed. |
… dev-jerry-apidetect
davidd-lunarg
approved these changes
May 21, 2024
|
Looks good, but it needs clang format before it can be merged. |
|
CI gfxreconstruct build queued with queue ID 189406. |
|
CI gfxreconstruct build # 4227 running. |
|
CI gfxreconstruct build # 4227 passed. |
locke-lunarg
pushed a commit
to locke-lunarg/gfxreconstruct
that referenced
this pull request
Jun 10, 2024
Problem For some cases, 1000 blocks is not enough for API detection. Solution If the first round detection with 1000 blocks doesn't return any detection result, we will do a second round API detection with no-block-limit parameter. The detection will be done with no block limit, till one of targeted API calls is found. A message will show in the console if the second round is needed. Result It looks for most cases, 1000 blocks should be enough for the API detection. The second round detection should always give us the result and it will be performed only the first round detection (short) doesn't provide any result.
locke-lunarg
pushed a commit
to locke-lunarg/gfxreconstruct
that referenced
this pull request
Jun 10, 2024
Problem For some cases, 1000 blocks is not enough for API detection. Solution If the first round detection with 1000 blocks doesn't return any detection result, we will do a second round API detection with no-block-limit parameter. The detection will be done with no block limit, till one of targeted API calls is found. A message will show in the console if the second round is needed. Result It looks for most cases, 1000 blocks should be enough for the API detection. The second round detection should always give us the result and it will be performed only the first round detection (short) doesn't provide any result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For some cases, 1000 blocks is not enough for API detection.
Solution
If the first round detection with 1000 blocks doesn't return any detection result, we will do a second round API detection with no-block-limit parameter. The detection will be done with no block limit, till one of targeted API calls is found. A message will show in the console if the second round is needed.
Result
It looks for most cases, 1000 blocks should be enough for the API detection. The second round detection should always give us the result and it will be performed only the first round detection (short) doesn't provide any result.