Separate dx12 codegen #1827
Separate dx12 codegen #1827
Conversation
MarkY-LunarG
requested review from
jzulauf-lunarg,
locke-lunarg,
bradgrantham-lunarg and
davidd-lunarg
|
CI gfxreconstruct build queued with queue ID 285599. |
|
CI gfxreconstruct build # 5166 running. |
|
CI gfxreconstruct build # 5166 passed. |
|
CI gfxreconstruct build queued with queue ID 286429. |
|
CI gfxreconstruct build # 5180 running. |
|
CI gfxreconstruct build # 5180 passed. |
|
Removed myself from reviewers in favor of @davidd-lunarg |
MarkY-LunarG
force-pushed
the
marky_separate_dx12_codegen
branch
from
d931ce6
to
edc3ef2
Compare
|
CI gfxreconstruct build # 5166 passed. |
|
Reverted |
MarkY-LunarG
force-pushed
the
marky_separate_dx12_codegen
branch
from
edc3ef2
to
d5f02fb
Compare
|
CI gfxreconstruct build queued with queue ID 288060. |
|
CI gfxreconstruct build # 5201 running. |
|
CI gfxreconstruct build queued with queue ID 288080. |
|
CI gfxreconstruct build # 5202 running. |
|
CI gfxreconstruct build # 5202 passed. |
MarkY-LunarG
force-pushed
the
marky_separate_dx12_codegen
branch
from
467a33f
to
a711f46
Compare
|
CI gfxreconstruct build queued with queue ID 288128. |
|
CI gfxreconstruct build # 5203 running. |
|
CI gfxreconstruct build # 5203 passed. |
Remove the hard-coded dependency of the DX12 GFXR codegen upon our Vulkan and the Khronos registry edit functionality (which the DX side really doesn't use). This includes removing the dependency on the "base_generators" directory as well. NOTE: This did require copying a functionality (like write) from the Khronos source to maintain consistency (so I added the Khronos copyright notice to the dx12_generators/base_generator.py file). The reason behind this is there are big changes coming to the Vulkan side in preparation of supporting other Khronos APIs and these changes could break DX12.
|
Squashing for merge, once it passes I will merge. |
MarkY-LunarG
force-pushed
the
marky_separate_dx12_codegen
branch
from
a711f46
to
ccd4009
Compare
|
CI gfxreconstruct build queued with queue ID 289377. |
|
CI gfxreconstruct build # 5216 running. |
|
CI gfxreconstruct build # 5216 passed. |
Separate out the DX12 codegen from the Vulkan codegen. The DX12 codegen was heavily tied in with the Vulkan codegen which leads to difficulty when trying to add in other Khronos API codegen (since we have to be careful of breaking other APIs).