Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CombineAndWriteToFile() now takes a file output as an argument #1838

Conversation

panos-lunarg
Copy link
Contributor

No description provided.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 288765.

@panos-lunarg
Copy link
Contributor Author

This should address an issue raised during code review of #1644

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5207 running.

@panos-lunarg panos-lunarg force-pushed the use_CombineAndWriteToFile_in_WriteFileHeader branch from 523d403 to d84bd4f Compare October 27, 2024 11:34
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 288785.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5208 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5208 passed.

Copy link
Contributor

@antonio-lunarg antonio-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@panos-lunarg panos-lunarg merged commit c33e781 into LunarG:dev Nov 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants