-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShaderGroupHandles: tracking/trimming #1844
ShaderGroupHandles: tracking/trimming #1844
Conversation
CI gfxreconstruct build queued with queue ID 290285. |
CI gfxreconstruct build # 5228 running. |
CI gfxreconstruct build # 5228 failed. |
6af34a1
to
544f570
Compare
CI gfxreconstruct build queued with queue ID 290314. |
CI gfxreconstruct build # 5229 running. |
CI gfxreconstruct build # 5229 passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions.
My big concern is the func call skipped.
Other than those concerns, because this will break the bi-sectable nature of the tree, I think when you commit it should be squashed to avoid this.
…ove a function-skip
CI gfxreconstruct build queued with queue ID 290875. |
CI gfxreconstruct build # 5234 running. |
CI gfxreconstruct build # 5234 passed. |
CI gfxreconstruct build queued with queue ID 290939. |
CI gfxreconstruct build # 5235 running. |
CI gfxreconstruct build # 5235 passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing really jumps out to me. I'm glad you have the hashmap tests, but I'm not sure how much they'll help. But I'd rather have more tests than not enough. So we can always strip them later if we feel they're not of much help.
- various changes to state-writer: always provide shader-group-handles - track bound pipelines in replay, retrieve map of old/new handles in CmdTraceRays - Add a generic murmur32-implementation to util/hash.h - Add a 'linear hashmap' type (cpu-flavor), populate with handles - Add unit-test for linear_hashmap
next in follow-up:
this PR belongs to #1526