Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShaderGroupHandles: tracking/trimming #1844

Merged
merged 10 commits into from
Nov 5, 2024

Conversation

fabian-lunarg
Copy link
Contributor

@fabian-lunarg fabian-lunarg commented Oct 29, 2024

  • various changes to state-writer: always provide shader-group-handles
  • track bound pipelines in replay, retrieve map of old/new handles in CmdTraceRays
  • Add a generic murmur32-implementation to util/hash.h
  • Add a 'linear hashmap' type (cpu-flavor), populate with handles
  • Add unit-test for linear_hashmap

next in follow-up:

  • TODO: linear hashmap gpu-flavor
  • TODO: run compute-shader over SBT, replace handles (in-place / shadow-buffer)

this PR belongs to #1526

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 290285.

@fabian-lunarg fabian-lunarg changed the title Fabian shader group handles ShaderGroupHandles: tracking/trimming Oct 29, 2024
@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5228 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5228 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 290314.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5229 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5229 passed.

Copy link
Contributor

@MarkY-LunarG MarkY-LunarG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of questions.
My big concern is the func call skipped.
Other than those concerns, because this will break the bi-sectable nature of the tree, I think when you commit it should be squashed to avoid this.

framework/generated/generated_vulkan_replay_consumer.cpp Outdated Show resolved Hide resolved
framework/util/hash.h Outdated Show resolved Hide resolved
framework/decode/vulkan_replay_consumer_base.cpp Outdated Show resolved Hide resolved
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 290875.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5234 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5234 passed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 290939.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5235 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5235 passed.

Copy link
Contributor

@MarkY-LunarG MarkY-LunarG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing really jumps out to me. I'm glad you have the hashmap tests, but I'm not sure how much they'll help. But I'd rather have more tests than not enough. So we can always strip them later if we feel they're not of much help.

@fabian-lunarg fabian-lunarg merged commit f20274b into LunarG:dev Nov 5, 2024
9 checks passed
beau-lunarg pushed a commit that referenced this pull request Nov 22, 2024
- various changes to state-writer: always provide shader-group-handles
- track bound pipelines in replay, retrieve map of old/new handles in CmdTraceRays
- Add a generic murmur32-implementation to util/hash.h
- Add a 'linear hashmap' type (cpu-flavor), populate with handles
- Add unit-test for linear_hashmap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants