Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: Fix leak and report error #1878

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

antonio-lunarg
Copy link
Contributor

Move data pitch check before opening the file and report an error on
invalid data pitch.

Related to #1853

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 306351.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5352 running.

Copy link
Contributor

@panos-lunarg panos-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did you encounter it at runtime or caught by reading the code?

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5352 passed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 309072.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5381 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 5381 passed.

Move data pitch check before opening the file and report an error on
invalid data pitch.
@antonio-lunarg antonio-lunarg merged commit 6759d05 into LunarG:dev Nov 26, 2024
9 checks passed
@antonio-lunarg antonio-lunarg deleted the antonio-write-image branch November 26, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants