Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

portable raytracing: Add VulkanAddressReplacer #1879

Open
wants to merge 25 commits into
base: dev
Choose a base branch
from
Open

portable raytracing: Add VulkanAddressReplacer #1879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
4c196b3
Add a VulkanAddressReplacer class, use in OverrideCmdTraceRays
fabian-lunarg Nov 5, 2024
1896b8c
VulkanAddressReplacer: work on buffer-creation/binding
fabian-lunarg Nov 18, 2024
6ec67f7
Override vkCmdPushConstant, save/restore push-constant state after cm…
fabian-lunarg Nov 18, 2024
ec97ae0
barriers using pre-synchronization2 API for compat
fabian-lunarg Nov 18, 2024
38bac98
provide a getter, rework some class-mechanics for proper moving
fabian-lunarg Nov 19, 2024
08935e3
select proper GetDeviceAddress flavour, refactoring
fabian-lunarg Nov 19, 2024
85c1daf
work on handling/passing VkPhysicalDeviceRayTracingPipelinePropertiesKHR
fabian-lunarg Nov 19, 2024
5e670d6
shadow-SBT creation
fabian-lunarg Nov 19, 2024
833334d
Add ProcessCmdBuildAccelerationStructuresKHR, lazy init of vulkan-res…
fabian-lunarg Nov 19, 2024
0d8c5e2
validation-fixes
fabian-lunarg Nov 19, 2024
063e39b
API-doc
fabian-lunarg Nov 20, 2024
95ac794
work on ProcessCmdBuildAccelerationStructuresKHR
fabian-lunarg Nov 20, 2024
ba492f8
Add bda-replacer shader, implement pipeline. looking good here
fabian-lunarg Nov 20, 2024
674f446
rebind-allocator: use VMA_ALLOCATOR_CREATE_BUFFER_DEVICE_ADDRESS_BIT
fabian-lunarg Nov 21, 2024
dc96856
comment out debug/test-flags
fabian-lunarg Nov 21, 2024
294a7ec
formatting fix as usual
fabian-lunarg Nov 21, 2024
503ebbd
compilation fixes for android and msvc
fabian-lunarg Nov 21, 2024
f023560
android: missing header
fabian-lunarg Nov 21, 2024
76e9492
msvc: avoid c++20 struct-initialization
fabian-lunarg Nov 21, 2024
e6d2f7b
VulkanAddresReplacer: bail out if group_handle_map is empty -> older …
fabian-lunarg Nov 21, 2024
65a3459
guard execution of replacer for vkCmdBuildAccelerationStructuresKHR
fabian-lunarg Nov 21, 2024
8f6fb55
guard execution of replacer for vkCmdTraceRays, goal is to fix backwa…
fabian-lunarg Nov 21, 2024
2e390bb
work on PR-feedback
fabian-lunarg Nov 21, 2024
66272c8
Roll back changes to vulkan_device_util, was causing weirdness in a s…
fabian-lunarg Nov 22, 2024
281a730
work review-comments, add GFXRECON_ASSERT for map-insert, place a no-…
fabian-lunarg Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions android/framework/decode/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ target_sources(gfxrecon_decode
${GFXRECON_SOURCE_DIR}/framework/decode/vulkan_decoder_base.cpp
${GFXRECON_SOURCE_DIR}/framework/decode/vulkan_default_allocator.h
${GFXRECON_SOURCE_DIR}/framework/decode/vulkan_default_allocator.cpp
${GFXRECON_SOURCE_DIR}/framework/decode/vulkan_address_replacer.h
${GFXRECON_SOURCE_DIR}/framework/decode/vulkan_address_replacer.cpp
antonio-lunarg marked this conversation as resolved.
Show resolved Hide resolved
${GFXRECON_SOURCE_DIR}/framework/decode/vulkan_address_replacer_shaders.h
${GFXRECON_SOURCE_DIR}/framework/decode/vulkan_device_address_tracker.h
${GFXRECON_SOURCE_DIR}/framework/decode/vulkan_device_address_tracker.cpp
${GFXRECON_SOURCE_DIR}/framework/decode/vulkan_captured_swapchain.h
Expand Down
2 changes: 1 addition & 1 deletion android/layer/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ android {
}
externalNativeBuild {
cmake {
cppFlags "-fexceptions", "-std=c++14", "-Wno-nullability-completeness"
cppFlags "-fexceptions", "-std=c++17", "-Wno-nullability-completeness"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi @bradgrantham - in this PR, I'm adjusting our android c++ dialect to c++17, matching the other configs.

arguments "-DANDROID_TOOLCHAIN=clang", "-DANDROID_STL=c++_static"
}
}
Expand Down
2 changes: 1 addition & 1 deletion android/tools/replay/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ android {
}
externalNativeBuild {
cmake {
cppFlags "-fexceptions", "-std=c++14", "-Wno-nullability-completeness"
cppFlags "-fexceptions", "-std=c++17", "-Wno-nullability-completeness"
arguments "-DANDROID_TOOLCHAIN=clang", "-DANDROID_STL=c++_static"
}
}
Expand Down
3 changes: 3 additions & 0 deletions framework/decode/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,9 @@ target_sources(gfxrecon_decode
${CMAKE_CURRENT_LIST_DIR}/vulkan_decoder_base.cpp
${CMAKE_CURRENT_LIST_DIR}/vulkan_default_allocator.h
${CMAKE_CURRENT_LIST_DIR}/vulkan_default_allocator.cpp
${CMAKE_CURRENT_LIST_DIR}/vulkan_address_replacer.h
${CMAKE_CURRENT_LIST_DIR}/vulkan_address_replacer.cpp
${CMAKE_CURRENT_LIST_DIR}/vulkan_address_replacer_shaders.h
${CMAKE_CURRENT_LIST_DIR}/vulkan_device_address_tracker.h
${CMAKE_CURRENT_LIST_DIR}/vulkan_device_address_tracker.cpp
${CMAKE_CURRENT_LIST_DIR}/vulkan_captured_swapchain.h
Expand Down
Loading
Loading