I added the endpoints for the todos (CURD) and then i added the tod #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…api.yaml file to the array in the generate.js file
|
Cool! Next step would be to merge IsraelOjiefoh#1, and then proper request, response bodied and status codes! 👍 |
Initial todo api spec
…arams, PUT and DELETE now route by ID
…arams, PUT and DELETE now route by ID
…es. -The todo-item-update schema uses oneOf to handle different required fields depending on the type of update.
… added npm/todo folder to the work-space created client.ts, root.ts, server.ts, and also todo.ts in the operation handler folder. It's time to start working now🚀
Every function of the api is now a seperate operation.
|
|
||
| export const addTodoOperationHandler: api.server.AddTodoItemOperationHandler<{}> = async (todo: string) => { | ||
| const createTodoCommand = new CreateTodo(todo); | ||
| const commandHandlers = new CommandHandlers(); |
There was a problem hiding this comment.
At some point this needs to be scoped to the server lifetime. So every server should have one commandHandlers object. There are various options to do this, like:
- use a global (absolutely not preferred!!)
- a hook (very "cool" and clean solution)
- create operationhandler in a factory, pass the command handlers to the factory
Let's discuss those options later! After implenting all the operationhandlers with dummy / example code
Operation handler update
…res a �undled folder inside the odo-api library but i don't know how to generate it. Please i want us to discuss this!!
use implicit types
|
|
||
| if (this.todos.has(todoId)) { | ||
| if (todoToUpdate) { | ||
| todoToUpdate.todoName = "Go to the gym"; |
added 2 commits
September 17, 2024 14:23
|
continue in #10 |
|
continue here, #10 is invalid |
IsraelOjiefoh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the endpoints for the todos (CURD) and then i added the todo-api.yaml file to the array in the generate.js file