Skip to content

Commit

Permalink
Tidy up #168, #170
Browse files Browse the repository at this point in the history
- Drop armv6 in README
- Remove unnecessary rsync step
- Remove some comments
  • Loading branch information
d7415 committed Dec 27, 2023
1 parent 859bda3 commit d10de82
Show file tree
Hide file tree
Showing 7 changed files with 4 additions and 20 deletions.
1 change: 0 additions & 1 deletion .github/workflows/build_push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ jobs:
context: .
file: ./Dockerfile
platforms: linux/amd64,linux/arm/v7,linux/arm64
# platforms: linux/amd64,linux/arm/v6,linux/arm/v7,linux/arm64
push: true
tags: |
lycheeorg/lychee:testing-${{ github.run_id }}
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/cron.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ jobs:
context: .
file: ./Dockerfile
platforms: linux/amd64,linux/arm/v7,linux/arm64
# platforms: linux/amd64,linux/arm/v6,linux/arm/v7,linux/arm64
push: true
tags: |
lycheeorg/lychee:testing-${{ github.run_id }}
Expand Down Expand Up @@ -66,7 +65,6 @@ jobs:
context: .
file: ./Dockerfile
platforms: linux/amd64,linux/arm/v7,linux/arm64
# platforms: linux/amd64,linux/arm/v6,linux/arm/v7,linux/arm64
push: true
build-args: |
COMPOSER_NO_DEV=0
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/pull.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ jobs:
context: .
file: ./Dockerfile
platforms: linux/amd64,linux/arm/v7,linux/arm64
# platforms: linux/amd64,linux/arm/v6,linux/arm/v7,linux/arm64
load: false
push: false
tags: |
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ jobs:
context: .
file: ./Dockerfile
platforms: linux/amd64,linux/arm/v7,linux/arm64
# platforms: linux/amd64,linux/arm/v6,linux/arm/v7,linux/arm64
push: true
build-args: |
TARGET=release
Expand Down
16 changes: 3 additions & 13 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ RUN \
gifsicle \
webp \
cron \
rsync \
composer \
unzip && \
addgroup --gid "$PGID" "$USER" && \
Expand Down Expand Up @@ -77,7 +76,7 @@ RUN \

# Multi-stage build: Build static assets
# This allows us to not include Node within the final container
FROM node:20 as node_modules_go_brrr
FROM node:20 as static_builder

RUN mkdir /app

Expand All @@ -89,18 +88,9 @@ RUN \
npm ci --no-audit && \
npm run build

# From our base container created above, we
# create our final image, adding in static
# assets that we generated above
# Get the static assets built in the previous step
FROM base

# Packages like Laravel Nova may have added assets to the public directory
# or maybe some custom assets were added manually! Either way, we merge
# in the assets we generated above rather than overwrite them
COPY --from=node_modules_go_brrr --chown=www-data:www-data /app/public /var/www/html/Lychee/public-npm
RUN rsync -ar /var/www/html/Lychee/public-npm/ /var/www/html/Lychee/public/ \
&& rm -rf /var/www/html/Lychee/public-npm \
&& chown -R www-data:www-data /var/www/html/Lychee/public
COPY --from=static_builder --chown=www-data:www-data /app/public /var/www/html/Lychee/public

# Add custom Nginx configuration
COPY default.conf /etc/nginx/nginx.conf
Expand Down
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
<br>
![Supports amd64 Architecture][amd64-shield]
![Supports arm64/aarch64 Architecture][arm64-shield]
![Supports armv6 Architecture][armv6-shield]
![Supports armv7 Architecture][armv7-shield]

## Notice: Dockerhub repository has been migrated to [lycheeorg/lychee](https://hub.docker.com/r/lycheeorg/lychee)
Expand Down Expand Up @@ -143,7 +142,6 @@ If you need to add (not change) nginx directives, files mounted in `/etc/nginx/c

[arm64-shield]: https://img.shields.io/badge/arm64-yes-success.svg?style=flat
[amd64-shield]: https://img.shields.io/badge/amd64-yes-success.svg?style=flat
[armv6-shield]: https://img.shields.io/badge/armv6-yes-success.svg?style=flat
[armv7-shield]: https://img.shields.io/badge/armv7-yes-success.svg?style=flat
[build-status-shield]: https://img.shields.io/github/actions/workflow/status/LycheeOrg/Lychee-Docker/cron.yml?label=%3Adev%20build
[docker-pulls-shield-old]: https://img.shields.io/docker/pulls/lycheeorg/lychee-laravel.svg?style=flat&label=Docker%20Pulls%20(lychee-laravel)
Expand Down
1 change: 1 addition & 0 deletions entrypoint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ echo '
| |__| |_| | (__| | | | __/ __/
|_____\__, |\___|_| |_|\___|\___|
|___/
-------------------------------------
Lychee Version: '$lycheeversion' ('$target')
Lychee Commit: '$shorthash'
Expand Down

0 comments on commit d10de82

Please sign in to comment.