Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix workflow test #191

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fix workflow test #191

merged 1 commit into from
Mar 1, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Mar 1, 2024

Comparison was with $test instead of ${{ github.event.inputs.branchname }} which would obviously break as $test is not defined.

Also added lychee into gitignore because when some-one does a git clone and subsequently docker compose up we do not want to see those files appear. :)

@ildyria ildyria requested a review from d7415 March 1, 2024 13:24
@ildyria
Copy link
Member Author

ildyria commented Mar 1, 2024

Fix is tested to work here:
https://github.com/LycheeOrg/Lychee-Docker/actions/runs/8112058445
was broken here:
https://github.com/LycheeOrg/Lychee-Docker/actions/runs/8111936708

d7415
d7415 approved these changes Mar 1, 2024
View reviewed changes
.github/workflows/build_branch.yml Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@ildyria ildyria merged commit 3aad496 into master Mar 1, 2024
8 checks passed
@ildyria ildyria deleted the fix-branch-to-docker branch March 1, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @d7415